Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk-coin-sol): jupiter swap tx support #5557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(sdk-coin-sol): jupiter swap tx support #5557

wants to merge 1 commit into from

Conversation

derekchen745
Copy link

Ticket: SC-1106

@derekchen745 derekchen745 force-pushed the derek/SC-1106-sol-jupiter-swap-tx branch 5 times, most recently from 67836f0 to 476dc7d Compare February 14, 2025 18:05
ewangbitgo
ewangbitgo reviewed Feb 14, 2025
View reviewed changes
modules/sdk-coin-sol/test/unit/jupiter.ts Outdated

const quoteResponse = await (
await fetch(
`https://api.jup.ag/swap/v1/quote?inputMint=${selling.address}&outputMint=${buying.address}&amount=${
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot go outside during unit test. use mocked data instead

@derekchen745 derekchen745 force-pushed the derek/SC-1106-sol-jupiter-swap-tx branch 6 times, most recently from 1aa7809 to 7e36926 Compare February 14, 2025 20:20
@derekchen745 derekchen745 marked this pull request as ready for review February 14, 2025 21:23
@derekchen745 derekchen745 requested review from a team as code owners February 14, 2025 21:23
@derekchen745 derekchen745 marked this pull request as draft February 14, 2025 21:45
@derekchen745 derekchen745 marked this pull request as ready for review February 15, 2025 22:53
@derekchen745 derekchen745 force-pushed the derek/SC-1106-sol-jupiter-swap-tx branch from 7e36926 to a2e425a Compare February 18, 2025 14:34
@derekchen745 derekchen745 force-pushed the derek/SC-1106-sol-jupiter-swap-tx branch from a2e425a to 536dcd8 Compare February 18, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewangbitgo ewangbitgo ewangbitgo left review comments

@pranavjain97 pranavjain97 Awaiting requested review from pranavjain97 pranavjain97 is a code owner automatically assigned from BitGo/wallet-platform

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo Awaiting requested review from mohammadalfaiyazbitgo mohammadalfaiyazbitgo is a code owner automatically assigned from BitGo/wallet-platform

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derekchen745 @ewangbitgo