feat: EdDSA Recovery Consolidation Support #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alia-bitgo
requested changes
Sep 7, 2023
| walletPassphrase: '', | ||
| startingScanIndex: 1, | ||
| endingScanIndex: 21, | ||
| seed: '', |
There was a problem hiding this comment.
an empty string is still considered a valid seed, to make sure this is correct:
Suggested change
| seed: '', | |
| seed: undefined, |
Adding support for EdDSA recovery consolidations for the following coins: Ada and Dot. Ticket: WP-570
mohammadalfaiyazbitgo
force-pushed
the
WP-570/MPC-Consolidation-UI
branch
from
cd4408e
to
946edda
Compare
alia-bitgo
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for EdDSA recovery consolidations
for the following coins: Ada and Dot.
Ticket: WP-570