fix: DI openSSLBytes #496
Merged
fix: DI openSSLBytes #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahin-mohammad
force-pushed
the
WP-2604/gg18-recovery
branch
from
afb129e
to
9137e62
Compare
zahin-mohammad
commented
Sep 5, 2024
Comment on lines
+318
to
+321
| ...parameters, | ||
| openSSLBytes, | ||
| }, | ||
| openSSLBytes |
There was a problem hiding this comment.
EVM takes it in the params, COSMOS like takes it as a second param...
zahin-mohammad
commented
Sep 5, 2024
| return new Error( | ||
| `Coin: ${coin} does not support v1 wallets sweep` | ||
| ); | ||
| ipcMain.handle('sweepV1', async (event, coin, parameters) => { |
alebusse
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unblocks recovery for ECDSA tss coins. A recent SDK change requires openSSLBytes to be dependency injected into the recover method.
In future prs we will remove opensslbytes all together from the TSS recovery flow.