Skip to content

Add silent payments address type to Glossary > Address page #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

yashrajd
Copy link
Contributor

@yashrajd yashrajd commented Jun 2, 2025

Copy link

netlify bot commented Jun 2, 2025

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit c946524
🔍 Latest deploy log https://app.netlify.com/projects/bitcoin-design-site/deploys/6842079005c42900080c3aaf
😎 Deploy Preview https://deploy-preview-1170--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GBKS GBKS requested a review from Copilot June 4, 2025 08:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new section to the Glossary > Address page detailing the silent payments address type and its unique properties.

  • Introduces the "Silent payments address" section
  • Explains how silent payments addresses differ from other address types and their UX benefits

@GBKS
Copy link
Contributor

GBKS commented Jun 5, 2025

Nice addition. Copilot had some recommendations to improve clarity and writing style. Up to you whether you want to adopt some of that.

image

Copy link
Collaborator

@swedishfrenchpress swedishfrenchpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Good addition.

....instead of "silent payments address"
removed repetitive verbiage; added explanation of improved UX while keeping length the same
@yashrajd
Copy link
Contributor Author

yashrajd commented Jun 5, 2025

Nice addition. Copilot had some recommendations to improve clarity and writing style. Up to you whether you want to adopt some of that.

image

Incorporated in c946524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Address page to include silent payments
3 participants