-
Notifications
You must be signed in to change notification settings - Fork 22
add export csv blockpit #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a new PR agains the updated codebase
With Blockpit, Could not parse timestamp -> because BlockPit has issues with these day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- check how the type works here
- it's better to send PRs with the same changes which were sent in a different pr (
sending
replacement)
headers: [ | ||
{ label: 'Date (UTC)', key: 'timestampExport' }, | ||
{ label: 'Integration Name', key: 'platform' }, | ||
{ label: 'Label', key: 'blockPitTxType' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the key be just type
instead of blockPitTxType
?
on line 125 it's type
BlockPit CSV integration #217
=> uFEFF=false is set for Blockpit to prevent adding a BOM (Byte Order Mark) to the CSV file, as Blockpit requires CSV files without BOM for successful import.
blockpit-csv-no-config-uFEFF.csv
blockpit-uFEFF-false.csv