create export csv for cryptotax #263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihomp
requested changes
Apr 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for exporting CSV data for a new "CryptoTax" platform and adjusts the header keys and data mappings accordingly.
- Added a new date formatter for the CryptoTax timestamp format.
- Updated CSV header configurations to include CryptoTax specific columns and adjusted currency mappings.
- Modified activity processing to handle CryptoTax fields alongside existing platforms.
Comments suppressed due to low confidence (2)
pages/admin/pro/history.js:363
- [nitpick] The update now sets sentCurrency using 'currency' rather than 'scvCurrency', while the Koinly fields still use 'scvCurrency'. Confirm that this change is intentional to avoid inconsistency in currency mapping.
res.activities[i].sentCurrency = sending ? currency : ''
pages/admin/pro/history.js:366
- [nitpick] Similar to sentCurrency, receivedCurrency now uses 'currency' instead of 'scvCurrency'. Verify that this change aligns with the intended usage for both display and Koinly CSV export.
res.activities[i].receivedCurrency = !sending ? currency : ''
pages/admin/pro/history.js
Outdated
Comment on lines
172
to
182
| { label: 'Quote Currency (Optional)', key: '' }, | ||
| { label: 'Quote Amount (Optional)', key: '' }, | ||
| { label: 'Fee Currency (Optional)', key: 'cryptoTaxFeeCurrencyCode' }, | ||
| { label: 'Fee Amount (Optional)', key: 'cryptoTaxFeeNumber' }, | ||
| { label: 'From (Optional)', key: '' }, | ||
| { label: 'To (Optional)', key: '' }, | ||
| { label: 'Blockchain (Optional)', key: '' }, | ||
| { label: 'ID (Optional)', key: 'hash' }, | ||
| { label: 'Description (Optional)', key: 'memo' }, | ||
| { label: 'Reference Price Per Unit (Optional)', key: '' }, | ||
| { label: 'Reference Price Currency (Optional)', key: '' } |
There was a problem hiding this comment.
The header configuration includes fields with empty key values. Consider providing explicit key names or removing these entries if they are not meant to map to data properties.
Suggested change
| { label: 'Quote Currency (Optional)', key: '' }, | |
| { label: 'Quote Amount (Optional)', key: '' }, | |
| { label: 'Fee Currency (Optional)', key: 'cryptoTaxFeeCurrencyCode' }, | |
| { label: 'Fee Amount (Optional)', key: 'cryptoTaxFeeNumber' }, | |
| { label: 'From (Optional)', key: '' }, | |
| { label: 'To (Optional)', key: '' }, | |
| { label: 'Blockchain (Optional)', key: '' }, | |
| { label: 'ID (Optional)', key: 'hash' }, | |
| { label: 'Description (Optional)', key: 'memo' }, | |
| { label: 'Reference Price Per Unit (Optional)', key: '' }, | |
| { label: 'Reference Price Currency (Optional)', key: '' } | |
| // { label: 'Quote Currency (Optional)', key: '' }, // Removed as it does not map to any data property | |
| // { label: 'Quote Amount (Optional)', key: '' }, // Removed as it does not map to any data property | |
| { label: 'Fee Currency (Optional)', key: 'cryptoTaxFeeCurrencyCode' }, | |
| { label: 'Fee Amount (Optional)', key: 'cryptoTaxFeeNumber' }, | |
| // { label: 'From (Optional)', key: '' }, // Removed as it does not map to any data property | |
| // { label: 'To (Optional)', key: '' }, // Removed as it does not map to any data property | |
| // { label: 'Blockchain (Optional)', key: '' }, // Removed as it does not map to any data property | |
| { label: 'ID (Optional)', key: 'hash' }, | |
| { label: 'Description (Optional)', key: 'memo' }, | |
| // { label: 'Reference Price Per Unit (Optional)', key: '' }, // Removed as it does not map to any data property | |
| // { label: 'Reference Price Currency (Optional)', key: '' } // Removed as it does not map to any data property |
Copilot uses AI. Check for mistakes.
ihomp
requested changes
May 5, 2025
| @@ -116,6 +121,12 @@ const processDataForExport = (activities, platform) => { | |||
| : Math.abs(activity.amountNumber) <= activity.txFeeNumber | |||
| ? 'Other Fee' | |||
| : 'Deposit' | |||
| } else if (platform === 'CryptoTax') { | |||
| processedActivity.cryptoTaxTxType = !sending | |||
There was a problem hiding this comment.
Shouldn't it be here processedActivity.type instead of processedActivity.cryptoTaxTxType?
because below you use type in headers
And that would also be good for consistency
| platform: 'CryptoTax', | ||
| headers: [ | ||
| { label: 'Timestamp (UTC)', key: 'timestampExport' }, | ||
| { label: 'Type', key: 'type' }, |
| @@ -375,6 +406,23 @@ export default function History({ queryAddress, selectedCurrency, setSelectedCur | |||
|
|
|||
| //sanitize memos for CSV | |||
| res.activities[i].memo = res.activities[i].memo?.replace(/"/g, "'") || '' | |||
|
|
|||
| // For CryptoTax platform | |||
There was a problem hiding this comment.
As it's specific for a platform, we shouldn't do it for everyone.
The code needs to be moved into the processDataForExport function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output:
crypto-tax-csv.csv
Test import
