JNG-6148 Request Parameters Support

[robertcsakany]

JNG-6148 Request Parameters Support

[coderabbitai]

Walkthrough

The changes introduce support for handling request parameters in the dispatching process. A new constant (REQUEST_PARAMETERS_KEY) is defined in the dispatcher to store incoming request parameters in the execution context. A dedicated class (RequestParametersVariableProvider) was added to retrieve these parameters. Additionally, both the Guice and Spring configuration files have been updated to register this provider under the "REQUEST" key in the variable resolver. These modifications collectively enable the application to capture, store, and resolve request parameters during runtime operations.

Changes

Files	Change Summary
judo-runtime-core-dispatcher/.../DefaultDispatcher.java judo-runtime-core-dispatcher/.../RequestParametersVariableProvider.java	Added a new constant REQUEST_PARAMETERS_KEY in DefaultDispatcher and introduced RequestParametersVariableProvider to retrieve request parameters from the context.
judo-runtime-core-guice/.../DefaultVariableResolverProvider.java judo-runtime-core-spring/.../JudoDefaultSpringConfiguration.java	Registered a new function with the key "REQUEST" using the RequestParametersVariableProvider to enhance variable resolution for request parameters.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant D as DefaultDispatcher
    participant CTX as Context
    participant VP as RequestParametersVariableProvider
    participant VR as VariableResolver

    C->>D: Initiate operation call with exchange (contains request parameters)
    D->>CTX: Check for REQUEST_PARAMETERS_KEY in exchange
    D->>CTX: Store request parameters using REQUEST_PARAMETERS_KEY
    Note over D,CTX: Request parameters are now available in context

    C->>VR: Request variable resolution for "REQUEST"
    VR->>VP: Invoke apply("parameterName")
    VP->>CTX: Retrieve map using REQUEST_PARAMETERS_KEY
    CTX-->>VP: Return request parameters map
    VP-->>VR: Return value for parameter
    VR-->>C: Return resolved value

Loading

Poem

I'm a rabbit in the code field,
Hopping to new features that are revealed.
A constant sprouts with parameters in tow,
Providers and resolvers making our app glow.
Celebrate the change—let's bounce, bounce, and go! 🐇✨

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

🧹 Nitpick comments (1)

judo-runtime-core-dispatcher/src/main/java/hu/blackbelt/judo/runtime/core/dispatcher/environment/RequestParametersVariableProvider.java (1)

34-34: Add type bounds to improve type safety.

The generic type T is unbounded, which could lead to unsafe type casting. Consider adding bounds to restrict the type parameter.

-public class RequestParametersVariableProvider<T> implements Function<String, T> {
+public class RequestParametersVariableProvider<T extends String> implements Function<String, T> {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c035a21 and 05066ce.

📒 Files selected for processing (4)

• judo-runtime-core-dispatcher/src/main/java/hu/blackbelt/judo/runtime/core/dispatcher/DefaultDispatcher.java (2 hunks)
• judo-runtime-core-dispatcher/src/main/java/hu/blackbelt/judo/runtime/core/dispatcher/environment/RequestParametersVariableProvider.java (1 hunks)
• judo-runtime-core-guice/src/main/java/hu/blackbelt/judo/runtime/core/guice/dispatcher/DefaultVariableResolverProvider.java (1 hunks)
• judo-runtime-core-spring/src/main/java/hu/blackbelt/judo/runtime/core/spring/JudoDefaultSpringConfiguration.java (1 hunks)

🔇 Additional comments (2)

judo-runtime-core-guice/src/main/java/hu/blackbelt/judo/runtime/core/guice/dispatcher/DefaultVariableResolverProvider.java (1)

52-52: LGTM!

The registration of the RequestParametersVariableProvider follows the established pattern and is consistent with other provider registrations.

judo-runtime-core-spring/src/main/java/hu/blackbelt/judo/runtime/core/spring/JudoDefaultSpringConfiguration.java (1)

406-406: LGTM!

The registration of the RequestParametersVariableProvider is consistent with both the Guice implementation and other provider registrations in this file.