Skip to content

JNG-6161 Replace direct UUID class reference to Serializable in SDK. #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Madmat8 merged 3 commits into from
Feb 14, 2025
Merged

JNG-6161 Replace direct UUID class reference to Serializable in SDK. #234

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd0fc88
JNG-6161 Initial feature commit [ci skip]
Madmat8 Feb 11, 2025
6b7e490
JNG-6161 [Release] Updating versions
Madmat8 Feb 14, 2025
7eb57cd
Merge branch 'develop' into feature/JNG-6161_replace_UUID_class_refer…
Madmat8 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
<judo-meta-keycloak-version>1.0.1.20241202_042226_cdd8af59_develop</judo-meta-keycloak-version>

<judo-dao-api-version>1.0.4.20250120_142441_62642c3f_develop</judo-dao-api-version>
<judo-sdk-common-version>1.0.4.20250211_142224_3a63f88f_develop</judo-sdk-common-version>
<judo-sdk-common-version>1.0.4.20250214_114554_71abc229_feature_JNG_6161_replace_UUID_class_references_to_Serializable</judo-sdk-common-version>
Copy link

@coderabbitai coderabbitai bot Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify compatibility with the new SDK version.

The update to judo-sdk-common introduces a breaking change where UUID class references are replaced with Serializable. While the version update aligns with the PR objectives, please ensure all UUID usages in the codebase are compatible with this change.

Run the following script to identify potential incompatibilities:

🏁 Script executed:

#!/bin/bash
# Description: Search for UUID usages that might need updates

# Search for UUID imports and usages
rg -l "java.util.UUID|UUID" --type java

# Search for method signatures or fields using UUID
ast-grep --pattern 'UUID $var'

Length of output: 1327

Action Required: Update UUID Usages for Compatibility

The updated judo-sdk-common-version now points to a feature branch that replaces direct UUID class references with Serializable. However, executing the compatibility script revealed that multiple modules (across jaxrs-cxf, dao-rdbms, dispatcher, guice, spring, and core) still reference java.util.UUID. Please verify if these usages are compatible with the new SDK changes or if they require refactoring to Serializable. Specifically, check the following files for potential breaking incompatibilities:

  • judo-runtime-core-jaxrs-cxf/src/main/java/hu/blackbelt/judo/runtime/core/jaxrs/cxf/interceptors/ExchangeIdDecorator.java
  • judo-runtime-core-dao-rdbms/src/main/java/hu/blackbelt/judo/runtime/core/dao/rdbms/executors/SelectStatementExecutor.java
  • judo-runtime-core-dao-rdbms/src/main/java/hu/blackbelt/judo/runtime/core/dao/rdbms/executors/AddReferenceStatementExecutor.java
  • judo-runtime-core-dao-rdbms/src/main/java/hu/blackbelt/judo/runtime/core/dao/rdbms/executors/RemoveReferenceStatementExecutor.java
  • judo-runtime-core-dispatcher/src/main/java/hu/blackbelt/judo/runtime/core/dispatcher/behaviours/ExportCall.java
  • judo-runtime-core-dao-rdbms/src/main/java/hu/blackbelt/judo/runtime/core/dao/rdbms/executors/StatementExecutor.java
  • judo-runtime-core-dao-rdbms/src/main/java/hu/blackbelt/judo/runtime/core/dao/rdbms/RdbmsReferenceUtil.java
  • judo-runtime-core-guice/src/main/java/hu/blackbelt/judo/runtime/core/guice/JudoDefaultModule.java
  • judo-runtime-core-guice/src/main/java/hu/blackbelt/judo/runtime/core/guice/core/UUIDIdentifierProviderProvider.java
  • judo-runtime-core-spring/src/main/java/hu/blackbelt/judo/runtime/core/spring/JudoBaseServiceConfiguration.java
  • judo-runtime-core/src/main/java/hu/blackbelt/judo/runtime/core/UUIDIdentifierProvider.java

Please update these sections as needed to ensure consistency with the Serializable-based API change.

<judo-dispatcher-api-version>1.0.3.20241127_150146_84f2988d_develop</judo-dispatcher-api-version>
<judo-operation-utils-version>1.1.3.20250121_041245_91c9b87a_develop</judo-operation-utils-version>

Expand Down
Loading