JNG-6310 Update epsilon #147
Conversation
robertcsakany
force-pushed
the
feature/JNG-6310_UpdateEpsilon
branch
from
87bfdc8 to
f896540
Compare
robertcsakany
requested review from
Madmat8,
bencegelei,
gaborflorian and
noherczeg
|
Warning Rate limit exceeded@robertcsakany has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 5 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe project has been updated to use Java 21 instead of Java 17 across all build, release, and IDE configuration files. Maven dependencies and plugin versions were also updated, including a Karaf upgrade and newer versions for several core and test libraries. No changes to public APIs or workflow logic were made. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Java Setup
participant Maven Build
GitHub Actions->>Java Setup: Set up JDK 21
Java Setup-->>GitHub Actions: JDK 21 ready
GitHub Actions->>Maven Build: Run build/test/release steps
Maven Build-->>GitHub Actions: Build/Test/Release results
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
pom.xml (1)
113-113:⚠️ Potential issueFix Sonar Java source property
sonar.java.sourcereferences undefined${java.version}. Either define<java.version>21</java.version>or change this to${maven.compiler.source}.
🧹 Nitpick comments (1)
pom.xml (1)
79-79: Remove duplicate<surefire-version>declarations
The<surefire-version>property appears twice (lines 79 and 106). Consolidate to a single definition to avoid confusion.Also applies to: 106-106
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (17)
.github/workflows/build-dependabot.yml(1 hunks).github/workflows/build.yml(1 hunks).github/workflows/bump-version.yml(1 hunks).github/workflows/create-release-on-master.yml(1 hunks).github/workflows/release.yml(1 hunks)judo-tatami-asm-validation/.classpath(1 hunks)judo-tatami-asm2expression/.classpath(1 hunks)judo-tatami-asm2keycloak/.classpath(1 hunks)judo-tatami-asm2rdbms/.classpath(1 hunks)judo-tatami-expression-asm-validation/.classpath(1 hunks)judo-tatami-expression-psm-validation/.classpath(1 hunks)judo-tatami-psm-validation/.classpath(1 hunks)judo-tatami-psm2asm/.classpath(1 hunks)judo-tatami-psm2measure/.classpath(1 hunks)judo-tatami-rdbms2liquibase/.classpath(1 hunks)judo-tatami-rdbms2liquibase/pom.xml(1 hunks)pom.xml(2 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/bump-version.yml
40-40: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/release.yml
40-40: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/create-release-on-master.yml
25-25: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/build-dependabot.yml
34-34: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/build.yml
37-37: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (23)
judo-tatami-psm2measure/.classpath (1)
3-3: Update JRE container to Java SE 21
The JRE container path has been updated to JavaSE-21, aligning this module with the project-wide Java version upgrade.judo-tatami-asm2rdbms/.classpath (1)
3-3: Update JRE container to Java SE 21
The JRE container path has been updated to JavaSE-21, ensuring consistency with the project’s Java version bump.judo-tatami-asm2expression/.classpath (1)
16-16: Update JRE container to Java SE 21
This entry now points to JavaSE-21, matching the overall upgrade across all modules.judo-tatami-psm-validation/.classpath (1)
16-16: Update JRE container to Java SE 21
The runtime container has been updated to JavaSE-21, consistent with the CI and IDE settings.judo-tatami-asm2keycloak/.classpath (1)
3-3: Update JRE container to Java SE 21
Updated the JRE container reference to JavaSE-21 to align with the project's standard Java version.judo-tatami-psm2asm/.classpath (1)
3-3: JRE container bump to JavaSE-21
Updated the Eclipse JRE container path to Java SE 21, aligning IDE settings with the project’s JDK upgrade.judo-tatami-asm-validation/.classpath (1)
16-16: JRE container bump to JavaSE-21
The JRE container entry now references Java SE 21, matching the cross-module Java version update.judo-tatami-expression-psm-validation/.classpath (1)
16-16: JRE container bump to JavaSE-21
Aligned the JRE container with Java 21 to ensure consistent IDE compilation settings.judo-tatami-expression-asm-validation/.classpath (1)
16-16: JRE container bump to JavaSE-21
Updated the Eclipse classpath entry to use Java SE 21 for this module’s IDE config.pom.xml (5)
68-69: Align compiler source/target to Java 21
Bumped<maven.compiler.source>and<maven.compiler.target>to 21 in line with the Java upgrade.
75-75: Karaf version upgrade
Updated<karaf-version>to 4.4.7 as part of the dependency refresh.
82-103: Verify all dependency-version properties
A large set of module version properties were updated with branch-specific identifiers. Please confirm that each referenced artifact has been published under these exact versions and that no stale values remain.
104-104: Xtext version bump
Upgraded<xtext-version>to 2.39.0, matching the broader dependency updates.
982-982: Update Sign Maven Plugin version
Bumpedsign-maven-pluginto 1.1.0; verify that the artifact signing process still functions correctly.judo-tatami-rdbms2liquibase/.classpath (1)
3-3: Upgrade Eclipse JRE container to JavaSE-21
The classpath entry now targets JavaSE-21. This aligns IDE settings with the project’s Java 21 upgrade..github/workflows/bump-version.yml (1)
39-43: Set up JDK 21 for version bump workflow
The Java setup step has been updated to use'21'(Zulu distribution), matching the project-wide move from Java 17 to Java 21.🧰 Tools
🪛 actionlint (1.7.7)
40-40: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/create-release-on-master.yml (1)
24-28: Update release-on-master workflow to JDK 21
The “Set up JDK” step now specifies Java 21 (Zulu), keeping release workflows consistent with the new baseline.🧰 Tools
🪛 actionlint (1.7.7)
25-25: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/build-dependabot.yml (1)
33-37: Switch Dependabot CI to JDK 21
Dependabot pull-request builds now install Java 21 (Zulu), aligning with the rest of the CI pipelines.🧰 Tools
🪛 actionlint (1.7.7)
34-34: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/build.yml (1)
36-40: Bump main build pipeline to JDK 21
The build job’s Java setup step now installs version 21 (Zulu), consistent with all other workflows.🧰 Tools
🪛 actionlint (1.7.7)
37-37: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
.github/workflows/release.yml (1)
39-44: Upgrade JDK version in release workflow.
This step now installs Java 21 instead of Java 17, keeping the release pipeline consistent with the project’s new baseline.🧰 Tools
🪛 actionlint (1.7.7)
40-40: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
judo-tatami-rdbms2liquibase/pom.xml (3)
137-141: Bump Testcontainers PostgreSQL to 1.21.1.
Aligns the PostgreSQL test container with the updated Java 21 environment.
144-147: Bump Testcontainers Core to 1.21.1.
Keeps the core Testcontainers library version in sync for stable test execution.
151-153: Bump Testcontainers JUnit Jupiter to 1.21.1.
Updates the JUnit integration module to match the latest Testcontainers release.
JNG-6310 Update epsilon