Skip to content

POC#4

Open
l3r8yJ wants to merge 1 commit intoBlamer-io:masterfrom
l3r8yJ:initial
Open

POC#4
l3r8yJ wants to merge 1 commit intoBlamer-io:masterfrom
l3r8yJ:initial

Conversation

@l3r8yJ
Copy link

@l3r8yJ l3r8yJ commented Jun 3, 2023

@h1alexbel take a look, please

part of POC


PR-Codex overview

This PR adds functionality for Blamer Notifications, a service that transfers GitHub notifications into text notifications for Telegram. It includes changes to configuration files, test files, and several Java classes.

Detailed summary

  • Added base-url and port to application-dev.yaml
  • Updated mvn.yaml to include java: [ 17, 20 ]
  • Added port and rsocket to application.yaml
  • Updated codecov.yaml with a to-do comment
  • Updated LICENSE.txt with a new copyright holder name
  • Updated README.md with a new logo and updated information
  • Added license headers to several Java files
  • Added TelegramUser and UpdateMessage classes
  • Added NotificationsAppEntry class
  • Added ExtWebClient class

The following files were skipped due to too many changes: src/main/java/io/blamer/notifications/extension/ExtWebClient.java, checkstyle-suppressions.xml, src/main/java/io/blamer/notifications/service/NotificationsGenerator.java, src/main/java/io/blamer/notifications/controller/NotificationsController.java, pom.xml, blamer-notifications.svg

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

<artifactId>spring-boot-starter-parent</artifactId>
<version>3.0.6</version>
<relativePath/>
<!-- lookup parent from repository -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ remove the comments please

<groupId>io.netty</groupId>
<artifactId>netty-resolver-dns-native-macos</artifactId>
<version>${netty-resolver-dns-native-macos.version}</version>
<classifier>osx-aarch_64</classifier>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ why do we need this dependency?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel netty doesn't work without it on m1 cpu

import lombok.extern.slf4j.Slf4j;
import org.springframework.http.HttpStatus;
import org.springframework.http.MediaType;
import org.springframework.web.bind.annotation.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ remove wildcard import

.map(
usr ->
this.webClient.post()
.uri("/api/v1/bot/updates")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ I think we can transfer messages to the hub initially

then from hub, we grooming the notifications and resend them to the bot

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants