Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Examples for new string functions and more #39

Merged
merged 4 commits into from
Dec 4, 2020
Merged

[WIP] Examples for new string functions and more #39

merged 4 commits into from
Dec 4, 2020

Conversation

wmalpica
Copy link

@wmalpica wmalpica commented Dec 2, 2020

No description provided.

William Malpica added 3 commits December 2, 2020 09:11
fixed sample_taxi.parquet so that the datetime columns that were stor…
2a47b9b 
…ed as strings are actually datetime. Added nation.parquet data for string testing. Added new datetime functions. Modified some of the other examples due to the sample_taxi.parquet changes
added more sql functions and improved current ones, including casting…
44240a4 
… and aggregations
Added SQRT
25d0dcb
drabastomek
drabastomek reviewed Dec 4, 2020
View reviewed changes
Copy link
Contributor

@drabastomek drabastomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are nit-picks but make for a better experience when we can avoid showing this ugly window that prompts the user to change kernel because this one doesn't exist.

docs/blazingsql/sql_reference/data_types.ipynb Outdated
@@ -166,9 +166,9 @@
],
"metadata": {
"kernelspec": {
"display_name": "RAPIDS Stable",
"display_name": "Python [conda env:bsql5] *",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might cause problems when run in the app. We should revert it back to RAPIDS Stable

docs/blazingsql/sql_reference/data_types.ipynb Outdated
"language": "python",
"name": "rapids-stable"
"name": "conda-env-bsql5-py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

docs/blazingsql/sql_reference/functions/binary_functions.ipynb Outdated
@@ -423,9 +423,9 @@
],
"metadata": {
"kernelspec": {
"display_name": "RAPIDS Nightly",
"display_name": "Python [conda env:bsql5] *",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

docs/blazingsql/sql_reference/functions/binary_functions.ipynb Outdated
"language": "python",
"name": "rapids-nightly"
"name": "conda-env-bsql5-py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

docs/blazingsql/sql_reference/functions/datetime_functions.ipynb Outdated
@@ -243,9 +264,9 @@
],
"metadata": {
"kernelspec": {
"display_name": "RAPIDS Stable",
"display_name": "Python [conda env:bsql5] *",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to RAPIDS-stable

docs/blazingsql/sql_reference/functions/string_functions.ipynb Outdated
"language": "python",
"name": "rapids-stable"
"name": "conda-env-bsql5-py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rapids-stable

docs/blazingsql/sql_reference/functions/unary_functions.ipynb Outdated
@@ -425,9 +455,9 @@
],
"metadata": {
"kernelspec": {
"display_name": "RAPIDS Nightly",
"display_name": "Python [conda env:bsql5] *",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAPIDS-stable

docs/blazingsql/sql_reference/functions/unary_functions.ipynb Outdated
"language": "python",
"name": "rapids-nightly"
"name": "conda-env-bsql5-py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAPIDS-stable

docs/blazingsql/sql_reference/general_sql.ipynb Outdated
@@ -1313,9 +827,9 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3.8.5 64-bit ('blazingsql2': conda)",
"display_name": "Python [conda env:bsql5] *",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAPIDS-stable

docs/blazingsql/sql_reference/general_sql.ipynb Outdated
"language": "python",
"name": "python38564bitblazingsql2conda33c057b4a2a24feea07ddd2b9511b885"
"name": "conda-env-bsql5-py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAPIDS-stable

@wmalpica wmalpica merged commit 8eb32d9 into master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drabastomek drabastomek drabastomek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmalpica @drabastomek