Skip to content

Conversation

@anonymusdennis
Copy link

the old api got removed as announced by curseforge this will fix it so that it may be used on the new API

I have no idea if i made errors in porting between versions
i just wanna get this out
here you go

the old api got removed as announced by curseforge 
this will fix it so that it may be used on the new API
@YoYoK3nny
Copy link
Contributor

YoYoK3nny commented Dec 27, 2022

Did you even try building with these changes? Your fork fails to build with the following unresolved references:

  • ConcurrentLinkedQueue (Not imported and results in a type mismatch)
  • httpClient (Line should be val res = internetManager.httpClient.newCall(request).execute(), note the lowercase i in internetManager. It matters)
  • string (Line 270 should be val jsonRes = JsonParser().parse(body.toString()).asJsonObject)

There are further issues that I won't go into, that is your job to sort out.

Regardless, the current master branch requires users to obtain their own API key for CurseForge to work. It is different to the released version (which at the time of posting this comment, is 6 commits behind the master branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants