Error messages not showing in toolbar (vibe-kanban) #246
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've successfully fixed the error message handling issue. The problem was that when rebase operations failed, the frontend was catching the detailed error from the API but displaying a generic "Failed to rebase branch" message instead. **What was wrong:** - Backend correctly returns `success: false` with detailed error messages - Frontend API handler correctly throws `ApiError` with the detailed message - But the rebase error handlers were ignoring the actual error message **What I fixed:** - Updated both rebase error handlers in [`CurrentAttempt.tsx`](file:///private/var/folders/kr/jdxkcn7129j376nrg0stj9zm0000gn/T/vibe-kanban/vk-c0ff-error-mess/frontend/src/components/tasks/Toolbar/CurrentAttempt.tsx#L350) to use `err.message` instead of generic text - Now displays detailed error messages like "Git service error: Merge conflicts: Rebase failed due to conflicts. Please resolve conflicts manually." The fix ensures users see the actual error details instead of unhelpful generic messages when operations fail.
…ssages - Frontend: Use actual error messages from API instead of generic "Failed to rebase branch" - Backend: Return proper HTTP error status codes (500) instead of 200 for rebase failures - Backend: Include detailed error messages in structured JSON error responses - Now users see specific error details like "Merge conflicts: Rebase failed due to conflicts" Amp-Thread: https://ampcode.com/threads/T-582a32d9-8dd9-4d43-a3b7-90e084d8c173 Co-authored-by: Amp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to perform an action, for example rebase, if it fails it just says "failed to rebase branch" in the UI, but in the API logs I can see
{
"success": false,
"data": null,
"message": "Git service error: Merge conflicts: Rebase failed due to conflicts. Please resolve conflicts manually."
}