feat: add support for regexp rules #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to matching and replacing image prefixes, this adds support
for using regexp patterns in exclusion and replacement rules.
This should allow to do any possible image transformation. When using a
regexp replacement rule, the replacement pattern can reference
submatches via `$N` where `N` is a number or `${name}` where `name` is
the name of a named capture group (e.g. `(?P<tag>.+)`).
martinohmann
force-pushed
the
regexp-rules
branch
from
cbeec63 to
1a02b73
Compare
Contributor
|
I couldn't agree 100% percent with the logic. If we are going to support regex so why we should have our own way of defining rules too? |
pesarkhobeee
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the nice-to-have mentioned in #1.
In addition to matching and replacing image prefixes, this adds support
for using regexp patterns in exclusion and replacement rules.
This should allow to do any possible image transformation. When using a
regexp replacement rule, the replacement pattern can reference
submatches via
$NwhereNis a number or${name}wherenameisthe name of a named capture group (e.g.
(?P<tag>.+)).