feat(oidc): improve token refresh and context handling #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gmpetpet
commented
Jul 11, 2025
gmpetpet
commented
- Update request context with new tokens after refresh, ensuring req.oidc always has the latest access, refresh, and ID tokens.
- Add user info to req.oidc after decoding ID token for easier access.
- Support locale in login options and authorization request.
- Refactor scope and prompt handling for login to prioritize options.
- Move isEntitled to request context for consistent entitlement checks.
- Improve test coverage for refresh and login flows.
- Refactor token fetch to use Authorization header when client secret is set.
- Update request context with new tokens after refresh, ensuring req.oidc always has the latest access, refresh, and ID tokens. - Add user info to req.oidc after decoding ID token for easier access. - Support locale in login options and authorization request. - Refactor scope and prompt handling for login to prioritize options. - Move isEntitled to request context for consistent entitlement checks. - Improve test coverage for refresh and login flows. - Refactor token fetch to use Authorization header when client secret is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.