Use meterPoint "direction" to detect export #1593
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The meterPoint graphql object has a "direction" enum value which indicates whether meters within are import or export meters. Update the query to include this direction field and use it to set whether an electricity meter is export.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing detection for export doesn't appear to be robust. For some reason for my export meter (I guess related to the ongoing saga I've been having with Octopus to set it up), both the
smartImportElectricityMeterandsmartExportElectricityMeterfields in the GraphQL response are None, which means the export meter gets detected as an import meter instead.Fortunately, the meterPoint GraphQL object includes a "direction" enum value which indicates whether meters within it are import or export meters.
This PR updates the query to fetch this direction field, and if present uses it to set whether an electricity meter is export. If the field is missing or none, it fails back to the old logic,
Fixes #1594