Skip to content

Add nix env vars to turbo passthrough #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Add nix env vars to turbo passthrough #2174

merged 1 commit into from
Jul 21, 2025

Conversation

imalsogreg
Copy link
Contributor

@imalsogreg imalsogreg commented Jul 20, 2025

Important

Add Nix and macOS-related environment variables to globalPassThroughEnv in turbo.json.

  • Environment Variables:
    • Added CMAKE_FRAMEWORK_PATH, NIX_CC, NIX_CC_WRAPPER_TARGET_HOST_aarch64_apple_darwin, NIX_BINTOOLS, NIX_BINTOOLS_WRAPPER_TARGET_HOST_aarch64_apple_darwin, CC, LD, MACOSX_DEPLOYMENT_TARGET to globalPassThroughEnv in turbo.json.

This description was created by Ellipsis for 7072f13. You can customize this summary. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jul 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
baml ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 0:10am

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 7072f13 in 51 seconds. Click for details.
  • Reviewed 21 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. turbo.json:15
  • Draft comment:
    New Nix-specific env vars (e.g. NIX_CC, NIX_CC_WRAPPER_TARGET_HOST_aarch64_apple_darwin) added. Confirm these are intended for passthrough and note they are architecture-specific.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_czX1thxIEq24uLsC

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@imalsogreg imalsogreg added this pull request to the merge queue Jul 21, 2025
Merged via the queue into canary with commit 7f95a4e Jul 21, 2025
23 checks passed
@imalsogreg imalsogreg deleted the greg/nix branch July 21, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant