remove source commenting to reenable zip download through ui #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Downloading full packages through the ui is failing. We cannot unzip the received zip
Description of the Change
Stop adding the comment at the beggining of the js, css file which causes a change in the final length of the file in bytes and might conflict with the length set in the .directory.txt
Alternate Designs
Add a query param 'no-comment' that can avoid to trigger the creation of this comment on demand, especially when downloading packages. This mean suffixing every path from .directory.txt files with ?no-comment=1
Release Notes
🐛 fix not being able to download full packages through the ui