Skip to content

Feature/115 rename memory to history #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jon-fox
Copy link
Contributor

@jon-fox jon-fox commented May 21, 2025

This PR renames all references from Memory to History across the codebase to improve clarity and reduce confusion between long-term memory and chat history. Key changes include:

  • memoryhistory
  • AgentMemoryChatHistory
  • atomic_agents directory → agent_history
  • test_agent_memory directory → test_agent_history

Tested:

  • Basic agent in atomic-agents to verify ChatHistory integration
  • Examples in atomic-examples that use ChatHistory
  • Readme examples to ensure chat history functionality works as expected

Closes #115.

@jon-fox
Copy link
Contributor Author

jon-fox commented May 21, 2025

I ran tests in my local for these changes to validate no issues, but I am also aware these are a ton of changes across many files. So it wouldn't hurt my feelings if further changes/tests are suggested or hesitancy in general with this pr.

@KennyVaneetvelde
Copy link
Member

KennyVaneetvelde commented May 22, 2025

Heya @jon-fox thanks for the contribution!

I'll see if I can get it merged today, this is a v2.0 change so the base branch should have been https://github.com/BrainBlend-AI/atomic-agents/tree/v2.0 - but I also still have to merge the current main into v2.0 so that we have the latest changes in there as well, which I'll be doing first today!

I'll keep you posted!

EDIT: Underestimated some of my other priorities today I am afraid, will attempt to take care of it tomorrow!

@KennyVaneetvelde KennyVaneetvelde changed the base branch from main to v2.0 May 23, 2025 13:15
@KennyVaneetvelde
Copy link
Member

Oh dear that's a lot of merge conflicts 😅 Was this PR a lot of work or was it a rather simple find&replace? Perhaps it's best to do it again using the v2.0 branch as base

@jon-fox
Copy link
Contributor Author

jon-fox commented May 23, 2025

No it was a pretty easy fix, the most time consuming thing was testing the packages to make sure no issues.

Edit: After looking at the number of conflicts it's probably easier if i just checkout v2.0 and redo the change, will close and re open this with another pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Rename Memory to History everywhere
2 participants