Skip to content

[scene_manager] Allow setting delimiters for CSV output #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

Breakthrough
Copy link
Owner

@Breakthrough Breakthrough commented Sep 30, 2024

Allows setting delimiters for both rows and columns for the write_scenes_list function as well as in the config file for the list-scenes command. #423

Outstanding Tasks:

  • Add CLI tests that verify output with goldens
  • Ensure CLI only allows 1-character separators are allowed (see TODO in code)
    • This is a limitation by the Python CSV module so this will only be enforced by the CLI to provide correct error messages to end users
  • Update changelog

@Breakthrough Breakthrough force-pushed the issue-423-csv_separator branch from 74b4747 to 9be43ba Compare September 30, 2024 03:46
@Breakthrough Breakthrough added this to the 0.6.5 milestone Sep 30, 2024
@Breakthrough Breakthrough linked an issue Sep 30, 2024 that may be closed by this pull request
@Breakthrough Breakthrough force-pushed the issue-423-csv_separator branch from 9be43ba to dc77965 Compare September 30, 2024 03:51
@Breakthrough Breakthrough force-pushed the issue-423-csv_separator branch from dc77965 to 7a81de2 Compare September 30, 2024 03:52
@Breakthrough Breakthrough requested a review from wjs018 October 19, 2024 23:47
@Breakthrough Breakthrough changed the base branch from output-pipeline to main October 19, 2024 23:48
@Breakthrough Breakthrough changed the base branch from main to output-pipeline October 19, 2024 23:48
@Breakthrough Breakthrough changed the base branch from output-pipeline to main October 19, 2024 23:52
@Breakthrough Breakthrough force-pushed the issue-423-csv_separator branch from 7a81de2 to 8a83222 Compare October 19, 2024 23:53
@Breakthrough Breakthrough marked this pull request as draft October 19, 2024 23:54
@Breakthrough Breakthrough force-pushed the issue-423-csv_separator branch 2 times, most recently from 3f49828 to c7353ac Compare October 21, 2024 01:36
@Breakthrough Breakthrough marked this pull request as ready for review October 21, 2024 02:08
@Breakthrough Breakthrough force-pushed the main branch 2 times, most recently from 85d1bdd to 2c55a55 Compare November 13, 2024 03:03
@Breakthrough Breakthrough force-pushed the issue-423-csv_separator branch from c8c2cd3 to b72e723 Compare November 13, 2024 03:06
@Breakthrough Breakthrough merged commit e1d86d9 into main Nov 20, 2024
42 checks passed
@Breakthrough Breakthrough deleted the issue-423-csv_separator branch November 20, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define csv separator
1 participant