PHNX-2108: Get data for row-content for quizzes #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajapac
requested review from
a team,
GurpinderSandhu and
jreardon-smith
and removed request for
a team
prajapac
requested review from
jstefaniuk-d2l,
mariellemanlulu and
cgordon-d2l
and removed request for
a team
mariellemanlulu
approved these changes
Oct 23, 2024
Letharrick
approved these changes
Oct 23, 2024
GurpinderSandhu
approved these changes
Oct 23, 2024
index.js
Outdated
| @@ -216,7 +216,8 @@ export const Rels = { | |||
| quiz: 'https://quizzes.api.brightspace.com/rels/quiz', | |||
| section: 'https://quizzes.api.brightspace.com/rels/quiz-section', | |||
| studyRecommendations: 'https://quizzes.api.brightspace.com/rels/studyRecommendations', | |||
| timing: 'https://quizzes.api.brightspace.com/rels/timing' | |||
| timing: 'https://quizzes.api.brightspace.com/rels/timing', | |||
| viewSubmissionResults: 'https://quizzes.api.brightspace.com/rels/view-quiz-submission-results' | |||
There was a problem hiding this comment.
submission is an interesting language choice here, is there a reason we are using that instead of say viewAttemptResults.
I also don't think we need to use the word quiz in-between view and submission, we are already in the Quiz subdomain.
There was a problem hiding this comment.
I named it that way to be consistent with the other consts, which generally seem to match the end of the url route, e.g. questionPool for https://quizzes.api.brightspace.com/rels/quiz-question-pool etc. 🤔
There was a problem hiding this comment.
After offline discussion, we decided to name the rel const to viewQuizSubmissionResults for consistency
jreardon-smith
approved these changes
Oct 29, 2024
…` for consistency
jreardon-smith
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Link: PHNX-2108
This PR adds a Quizzes.viewSubmissionResults Rel (
https://quizzes.api.brightspace.com/rels/view-quiz-submission-results). This is added for explicitly differentiating thesubmissionLinkin theactor-quiz-attempt-activity-provider(vs. just looking for therelative-urisub-entity), see related PRs below.Related PRs