BREAKING CHANGE: Migrate to Jest and Webpack to be more compatible with Lit 3 #118
BREAKING CHANGE: Migrate to Jest and Webpack to be more compatible with Lit 3 #118
Conversation
wladco
changed the title
wladco
requested review from
a team,
br-cz and
prajapac
and removed request for
a team
brissons
left a comment
brissons
left a comment
There was a problem hiding this comment.
a couple of nits but otherwise lgtm!
| "jsx": true | ||
| } | ||
| }, | ||
| "ecmaVersion": 2018 |
There was a problem hiding this comment.
Unfortunately, the last version this code works with is the 2018
|
|
||
| var React = require('react'), //eslint-disable-line no-unused-vars | ||
| TestUtils = require( 'react-addons-test-utils' ), | ||
| var React = require('react'), //eslint-disable-line no-unused- |
There was a problem hiding this comment.
nit: is //eslint-disable-line no-unused- still required?
|
|
||
| it('should render wrapper with expected class name', function() { | ||
| var elem = TestUtils.renderIntoDocument( | ||
|
|
There was a problem hiding this comment.
nit: Is this newline intentionally added?
|
|
||
| it('should return a view', function() { | ||
| var viewer = ImagePlugin.getComponent(); | ||
| var viewer = ImagePlugin.getComponent({src: 'test'}); |
There was a problem hiding this comment.
For the test in src/plugins/html/__tests__/htmlPluginTests.js, the file ends in .html, i.e. src: 'test.html', should this have the extension too, or perhaps the other test shouldn't have it? 🤔
There was a problem hiding this comment.
Thx, any value will do here, so I removed the .html for consistency
jest.config.js
Outdated
| // ORIGINAL COMMENT FROM REMOVED KARMA CONFIG: | ||
| // There's a pre-test stall on Travis builds that can cause Karma to | ||
| // fail with the default timeout of 10s. I'm not sure what's causing | ||
| // the stall, but this mitigates it for now. | ||
| // | ||
| // KEEPING THE TIMEOUT JUST IN CASE |
There was a problem hiding this comment.
We don't use Travis for builds anymore (should be GitHub Actions), so I wonder if the comment/timeout is still relevant 🤔
|
|
||
| it('should return a view', function() { | ||
| var viewer = GenericPlugin.getComponent(); | ||
| var viewer = GenericPlugin.getComponent({src: 'test'}); |
There was a problem hiding this comment.
Same comment as for src/plugins/image/__tests__/imagePluginTests.js file
There was a problem hiding this comment.
Out of curiosity, what led to this var name change from native to plugin?
There was a problem hiding this comment.
It's weird, but test fails with ReferenceError: native is not defined if we name this variable differently from exported here
wladco
changed the title
…th Lit 3 (#118) BREAKING CHANGE: Migrate to Jest and Webpack to be more compatible with Lit 3
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
Related jira:
https://desire2learn.atlassian.net/browse/PHNX-1954
This PR:
Karma, Browserify, BabelifywithJest, Webpack.bump-react-valence-ui-iframe.Why do we need this?
While configuring the
Babelifyfor Lit 3, we had to update some dependencies that bring along others. As a result, we arrive at a configuration where we can no longer stably work withReactversions earlier than16.Why Jest?
Jest is perfectly compatible with React. It debugs well and doesn't require a bundler to execute tests.