Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Status Icon component #417

Merged
merged 6 commits into from
Oct 10, 2024
Merged

feat: Add Status Icon component #417

merged 6 commits into from
Oct 10, 2024

Conversation

GZolla
Copy link
Contributor

@GZolla GZolla commented Oct 9, 2024

@GZolla GZolla marked this pull request as ready for review October 10, 2024 05:08
@GZolla GZolla requested a review from a team as a code owner October 10, 2024 05:08
src/components/status-icon/README.md Outdated Show resolved Hide resolved
Comment on lines 21 to 28
## Installation

To install from NPM:

```shell
npm install @brightspace-ui-labs/status-icon
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section too.

Suggested change
## Installation
To install from NPM:
```shell
npm install @brightspace-ui-labs/status-icon
```

src/components/status-icon/README.md Outdated Show resolved Hide resolved
<d2l-labs-status-icon state="failure" message="Failure"></d2l-labs-status-icon>
```

![Status Icons preview](./StatusIconPreview.PNG)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be OK if we didn't include a preview screenshot here... they get out of date so quickly and we don't do it with any others.

src/components/status-icon/status-icon.js Outdated Show resolved Hide resolved
test/components/status-icon/status-icon.test.js Outdated Show resolved Hide resolved
@GZolla GZolla changed the title Add Status Icon component feat: Add Status Icon component Oct 10, 2024
@GZolla GZolla merged commit efd8631 into main Oct 10, 2024
3 checks passed
@GZolla GZolla deleted the gzolla/add-status-icon branch October 10, 2024 16:28
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants