Skip to content

Conversation

@PixelGames987
Copy link
Contributor

Proposed Changes

This pull request adds a way to run single IR payloads from the Files app instead of going back to IR > custom IR.

Types of Changes

This is a simple, new feature.

Verification

The new single ir function works exactly the same as going into IR > custom IR > selecting a file > custom cmd.

User-Facing Change

NONE

@bmorcelli
Copy link
Member

Why not split the function otherIRcodes() in 2, where otherIRcodes will call this second function running the file?

https://github.com/BruceDevices/firmware/blob/dev/src%2Fmodules%2Fir%2Fcustom_ir.cpp#L219

I say it because with your suggestion we have 2 functions doing practically the same thing...

Running .ir file from Files is good, but it is also good to choose between "Choose a cmd" and "Spam all cmds", because most .ir files have multiple commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants