Added an IR custom command function to IR files in the "Files" app#1948
Merged
bmorcelli merged 2 commits intoBruceDevices:devfrom Jan 3, 2026
Merged
Added an IR custom command function to IR files in the "Files" app#1948bmorcelli merged 2 commits intoBruceDevices:devfrom
bmorcelli merged 2 commits intoBruceDevices:devfrom
Conversation
Member
|
Why not split the function otherIRcodes() in 2, where otherIRcodes will call this second function running the file? https://github.com/BruceDevices/firmware/blob/dev/src%2Fmodules%2Fir%2Fcustom_ir.cpp#L219 I say it because with your suggestion we have 2 functions doing practically the same thing... Running .ir file from Files is good, but it is also good to choose between "Choose a cmd" and "Spam all cmds", because most .ir files have multiple commands. |
Contributor
Author
|
I don't know if i understood correctly, but I optimized the code and made the custom ir cmd just call the old function |
Member
|
Perfect!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request adds a way to run single IR payloads from the Files app instead of going back to IR > custom IR.
Types of Changes
This is a simple, new feature.
Verification
The new single ir function works exactly the same as going into IR > custom IR > selecting a file > custom cmd.
User-Facing Change