fix: guard api to builder only #17646
Open
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cubic-dev-ai review this pull request |
Contributor
@Dakuan I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
adrinr
reviewed
Dec 19, 2025
|
|
||
| export async function fetch(ctx: UserCtx<void, FetchRowsResponse>) { | ||
| const { tableId } = utils.getSourceId(ctx) | ||
| if (!isExternalTableID(tableId)) { |
Member
There was a problem hiding this comment.
I think this should be done in the internal.ts implementation, not here.
Contributor
Author
There was a problem hiding this comment.
hmm i did consider that, but felt authy concerns should be nearer the API boundary, lets chat monday!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Guarded the row fetch endpoint so only builders can access internal dev-only tables. Non-builders now get a 404 in production instead of seeing dev-only tables. External tables are unaffected.
Written for commit f6b5b15. Summary will update on new commits.