fix: rescue tombstoned prod tables

[Dakuan]

Summary by cubic

Rescues tombstoned prod table docs during publish by restoring table metadata when prod has live rows, preventing broken tables and data loss.

• Bug Fixes
  • Before replication, detect prod tables with live rows but missing/tombstoned table docs and restore them from dev (preserving prod _rev when present).
  • Paginated scan of row docs to find affected table IDs, honoring tablesToSeed and skipping USER_METADATA; added a test confirming the table doc is revived and both dev/prod rows remain.

^{Written for commit b9345a2. Summary will update on new commits.}

[Dakuan]

@cubic-dev-ai

[cubic-dev-ai]

@cubic-dev-ai

@Dakuan I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

[adrinr]

This works fine, I managed to reproduce he issue locally. I am just worried about the performance of it. Instead of relying on the rows, that can be millions, we should probably compare the list of tables in dev vs the ones in prod. Otherwise publishing workspaces with a lot of rows will cause delays

[Dakuan]

@cubic-dev-ai

[cubic-dev-ai]

@cubic-dev-ai

@Dakuan I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

1 issue found across 2 files

Confidence score: 3/5

• The unreachable if (prodTable._deleted) branch in packages/server/src/api/controllers/deploy/index.ts means the expected revision for tombstoned tables is never captured, so deploy logic can’t handle deleted documents correctly.
• This gap could surface as failed or inconsistent deploys when production documents were previously deleted, giving the change a meaningful regression risk.
• Pay close attention to packages/server/src/api/controllers/deploy/index.ts - confirm tombstoned documents are handled without relying on an unreachable _deleted branch.

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/server/src/api/controllers/deploy/index.ts">

<violation number="1" location="packages/server/src/api/controllers/deploy/index.ts:306">
P1: The `if (prodTable._deleted)` branch is unreachable. CouchDB returns 404 for tombstoned documents, so `tryGet` returns `undefined` rather than a doc with `_deleted: true`. The `prodRev` will never be captured for tombstoned tables, which may cause conflict errors when putting the rescued doc. Consider using `allDocs` with `keys: [tableId]` which can return deleted doc metadata, or fetch with explicit revision.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: The if (prodTable._deleted) branch is unreachable. CouchDB returns 404 for tombstoned documents, so tryGet returns undefined rather than a doc with _deleted: true. The prodRev will never be captured for tombstoned tables, which may cause conflict errors when putting the rescued doc. Consider using allDocs with keys: [tableId] which can return deleted doc metadata, or fetch with explicit revision.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/server/src/api/controllers/deploy/index.ts, line 306:

<comment>The `if (prodTable._deleted)` branch is unreachable. CouchDB returns 404 for tombstoned documents, so `tryGet` returns `undefined` rather than a doc with `_deleted: true`. The `prodRev` will never be captured for tombstoned tables, which may cause conflict errors when putting the rescued doc. Consider using `allDocs` with `keys: [tableId]` which can return deleted doc metadata, or fetch with explicit revision.</comment>

<file context>
@@ -185,6 +187,168 @@ async function applyPendingColumnRenames(
+          targets.push({ tableId })
+          continue
+        }
+        if (prodTable._deleted) {
+          targets.push({ tableId, prodRev: prodTable._rev })
+        }
</file context>