Skip to content

feat: auto-close menus and adjust logo size when navbar collapses #17717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
poirazis wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: auto-close menus and adjust logo size when navbar collapses #17717

poirazis wants to merge 3 commits into from
+40 −3

Conversation

@poirazis
Copy link
Contributor

@poirazis poirazis commented Jan 8, 2026 •
edited
Loading

  • Menus automatically close when collapsible navbar is collapsed
  • Menu state is persisted and restored when navbar expands
  • Logo height is capped at 32px when collapsible is enabled to prevent navbar overflow
  • Ensures smooth UX without unnecessary scrolling in collapsible mode

addresses #17659

@poirazis
feat: auto-close menus and adjust logo size when navbar collapses
29f5d12 
- Menus automatically close when collapsible navbar is collapsed
- Menu state is persisted and restored when navbar expands
- Logo height is capped at 32px when collapsible is enabled to prevent navbar overflow
- Ensures smooth UX without unnecessary scrolling in collapsible mode
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@NDCallahan
Copy link

NDCallahan commented Jan 9, 2026 •
edited
Loading

just a note from an implementer's perspective:

Logo height is capped at 32px when collapsible is enabled to prevent navbar overflow

I don't think limiting the size to 32px is the right approach for the logo in the navigation bar. Perhaps it's good enough temporarily, but I foresee others wanting to utilize a logo from a navigation perspective and not be capped at 32 px. I did create #issue17659 so perhaps this is sufficient for now.

EDITS
I could see the logo being capped, when the navigation bar collapses, but not when collapse is enabled. To do this, why wouldn't the logo dynamically decrease in size within the parent element?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@poirazis @NDCallahan @melohagan