Skip to content

Conversation

@melohagan
Copy link
Collaborator

@melohagan melohagan commented Jan 15, 2026

Description

Use Nx affected results to gate heavy CI test jobs so unrelated PRs skip server/worker/library tests.

Launchcontrol

Speed up PR CI by running only tests for affected projects.


Summary by cubic

Run only affected CI test jobs using Nx to shorten PR build times while keeping full coverage when needed.

  • Refactors
    • Added a determine-affected job that uses Nx (base: NX_BASE_BRANCH) to find changed projects.
    • Outputs flags (server, worker, builder, libraries) and gates test-libraries, test-worker, and test-server with needs/if conditions.
    • Library tests always run.
    • Fallback: when ONLY_AFFECTED_TASKS is false, all test jobs run.

Written for commit 6ae9784. Summary will update on new commits.

@melohagan melohagan marked this pull request as ready for review January 15, 2026 16:24
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/budibase_ci.yml">

<violation number="1" location=".github/workflows/budibase_ci.yml:73">
P1: The `test_libraries` variable is never set in the affected code path but is still output on line 97. Since the initialization (`test_libraries=false`) and calculation logic were removed, `$test_libraries` will be empty/unset, causing the `test-libraries` job to be skipped on all PRs. Either add back the `test_libraries` calculation or update it to use `libraries` directly (since `libraries` is now always `true` in this branch).</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants