Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating the Batch page #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

leojay-net
Copy link

@leojay-net leojay-net commented Mar 15, 2025

Description

I created a page.tsx file in the app/builders/[address]/ directory and implemented a component to display my profile/Batch page. The component features an avatar, full name, nickname, wallet address, an 'About' section, and a 'Socials' section, providing a comprehensive overview of my profile.

Additional Information

Related Issues

_Closes #8

Your ENS/address:

0xA35D2C518710D3f953Ce4F69CDDEAaFc0c6b156c

Copy link

vercel bot commented Mar 15, 2025

@leojay-net is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@leojay-net leojay-net marked this pull request as ready for review March 15, 2025 19:27
@leojay-net
Copy link
Author

@melanke

Copy link

vercel bot commented Mar 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch14.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2025 10:56am

Copy link
Collaborator

@melanke melanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your personal page!

I'd like to ask you to add a screenshot of it in the PR description. This will help us better situate where we are among many other PRs. Thanks!

Here are some points for improvement:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR's only purpose is to add your personal page to the project.
However, it also includes code related to the Check-in.

Please make sure to remove any unrelated code from this PR.
Let me know on Telegram if you need help doing that with Git.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is also unrelated to your personal page, please remove it from the PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is also unrelated to your personal page, please remove it from the PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is also unrelated to your personal page, please remove it from the PR.

</h1>
<div className="flex items-center gap-2 mt-1">
<div className="px-2 py-1 bg-gray-100 rounded-full text-xs font-medium text-blue-600 flex items-center">
<span>{truncateAddress(walletAddress)}</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a component in the project specifically for displaying addresses in a visually appealing way. You should check it out.

rel="noopener noreferrer"
aria-label={`${link.platform} profile`}
>
<img src={link.icon} alt={link.platform} className="w-full h-full object-cover" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended to use Next's <Image> component for better performance when displaying images.

<div className="flex flex-col items-center md:flex-row md:gap-6">
{/* Avatar */}
<div className="w-28 h-28 rounded-full border-4 border-gray-200 shadow-lg overflow-hidden">
<img src={avatarUrl} alt={name} className="w-full h-full object-cover" />
Copy link
Collaborator

@melanke melanke Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Next's <Image> here as well.

import React, { useState } from "react";
import { Check, Copy, ExternalLink } from "lucide-react";

const Web3Profile = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there will be many profiles, give your page a unique name. Use your name or nickname.

And it's also a good idea to explicitly add the NextPage type.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is also unrelated to your personal page, please remove it from the PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not using Chai, Hardhat, or Mocha on your personal page, so it's better to remove them.

Also, there are many unrelated changes in yarn.lock. I recommend resetting the file and reinstalling the dependencies so that only the changes related to lucide-react remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants