Completed task-a and task-b #24

GulAhmedshah · 2025-07-11T21:26:37Z

Description

Added my personal page named pag.tsx. The following is the screenshot of my page.

Additional Information

I have read the contributing docs (if this is your first contribution)
This is not a duplicate of any existing pull request

Related Issues

_Closes #8

Your ENS/address: 0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3

vercel · 2025-07-11T21:26:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
batch18.buidlguidl.com	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 9:59pm

melanke

Hello, thank you for your personal page! :)

I’d like to ask you to improve your PR’s description:

Please add a screenshot of what your page looks like. This is a common practice in many open-source projects, making it easier for reviewers to identify issues and navigate through the many PRs we have to review.
This PR should only solve issue #8. You can remove the mention of #9. To properly link the task, use # followed by the issue number.
Add your Ethereum address or ENS domain — no need to include your Telegram name.
Checkboxes should have an x in the middle as part of Markdown formatting.

And here comes my review. Things I think you should improve in your code:

melanke · 2025-07-14T15:36:55Z

packages/hardhat/contracts/CheckIn.sol

Oops! I think you're sending this file by mistake. It's completely unrelated to your personal page, so please keep it outside of this PR. Let me know if you need help removing it from the PR using Git.

melanke · 2025-07-14T15:37:10Z

packages/hardhat/deploy/00_deploy_your_contract.ts

This change is also unrelated to your personal page, please remove it from the PR.

melanke · 2025-07-14T15:37:59Z

packages/nextjs/app/builders/0x307F9e12F738d3Aa9B4373B5B68BDD7C3Dc2FCf6/page.tsx

You are removing another builder's page. Please, revert this change.

melanke · 2025-07-14T15:38:06Z

packages/nextjs/contracts/deployedContracts.ts

This change is also unrelated to your personal page, please remove it from the PR.

packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx

melanke · 2025-07-14T15:39:25Z

packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx

+      style={{
+        minHeight: "100vh",
+        background: "linear-gradient(135deg, #e0e7ff 0%, #f0fdfa 100%)",
+        display: "flex",
+        alignItems: "center",
+        justifyContent: "center",
+        fontFamily: "Inter, Arial, sans-serif",
+      }}


This project follows the utility-first CSS approach, meaning we find it easier to read and style the code by adding pre-built CSS classes directly to the HTML. We're using Tailwind 4.1.3. I suggest checking out its documentation and the rest of the project code. I assure you the learning curve is easy.

packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx

GulAhmedshah · 2025-07-14T21:50:40Z

Hi sir! I mad the required changes but I think I have messed up while pushing these commits. At first I have used hard reset to go in earlier position of the project and then faced problem to push the the new changes/code so searched online and did some rebasing thing. Now I don't know I have did thing in right way or not. Please help me out in this regard.

GulAhmedshah · 2025-07-14T22:04:09Z

Hi sir! I mad the required changes but I think I have messed up while pushing these commits. At first I have used hard reset to go in earlier position of the project and then faced problem to push the the new changes/code so searched online and did some rebasing thing. Now I don't know I have did thing in right way or not. Please help me out in this regard.

…

On Mon, Jul 14, 2025 at 8:46 PM Gil Lopes Bueno ***@***.***> wrote: ***@***.**** requested changes on this pull request. Hello, thank you for your personal page! :) I’d like to ask you to improve your PR’s description: - Please add a screenshot of what your page looks like. This is a common practice in many open-source projects, making it easier for reviewers to identify issues and navigate through the many PRs we have to review. - This PR should only solve issue #8 <#8>. You can remove the mention of #9 <#9>. To properly link the task, use # followed by the issue number. - Add your Ethereum address or ENS domain — no need to include your Telegram name. - Checkboxes should have an x in the middle as part of Markdown formatting. And here comes my review. Things I think you should improve in your code: ------------------------------ On packages/hardhat/contracts/CheckIn.sol <#24 (comment)> : Oops! I think you're sending this file by mistake. It's completely unrelated to your personal page, so please keep it outside of this PR. Let me know if you need help removing it from the PR using Git. ------------------------------ On packages/hardhat/deploy/00_deploy_your_contract.ts <#24 (comment)> : This change is also unrelated to your personal page, please remove it from the PR. ------------------------------ On packages/nextjs/app/builders/0x307F9e12F738d3Aa9B4373B5B68BDD7C3Dc2FCf6/page.tsx <#24 (comment)> : You are removing another builder's page. Please, revert this change. ------------------------------ On packages/nextjs/contracts/deployedContracts.ts <#24 (comment)> : This change is also unrelated to your personal page, please remove it from the PR. ------------------------------ In packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx <#24 (comment)> : > @@ -0,0 +1,107 @@ +// app/builder/address/page.tsx + +const AVATAR_URL = "https://avatars.githubusercontent.com/u/583231?v=4"; +const WALLET_ADDRESS = "0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3"; + +const SOCIALS = [ + { name: "Twitter", url: "https://twitter.com/yourhandle", icon: "🐦" }, + { name: "GitHub", url: "https://github.com/yourhandle", icon: "💻" }, + { name: "LinkedIn", url: "https://linkedin.com/in/yourhandle", icon: "🔗" }, +]; + +export default function Web3ProfilePage() { You might want to consider typing your page as NextPage since we are using TypeScript, as this ensures better integration and adds clarity for future maintainers by indicating that the component is a Next.js page. ------------------------------ In packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx <#24 (comment)> : > + style={{ + minHeight: "100vh", + background: "linear-gradient(135deg, #e0e7ff 0%, #f0fdfa 100%)", + display: "flex", + alignItems: "center", + justifyContent: "center", + fontFamily: "Inter, Arial, sans-serif", + }} This project follows the utility-first CSS approach, meaning we find it easier to read and style the code by adding pre-built CSS classes directly to the HTML. We're using Tailwind 4.1.3. I suggest checking out its documentation and the rest of the project code. I assure you the learning curve is easy. ------------------------------ In packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx <#24 (comment)> : > + <img + src={AVATAR_URL} + alt="Avatar" + style={{ + width: "100px", + height: "100px", + borderRadius: "50%", + objectFit: "cover", + boxShadow: "0 2px 8px rgba(0,0,0,0.10)", + marginBottom: "18px", + }} + /> Consider using Next.js's <Image> component for better performance and built-in optimizations like lazy loading and responsive sizing. — Reply to this email directly, view it on GitHub <#24 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BQKFU6NDIZLMKHV44JZKEVT3IPGFLAVCNFSM6AAAAACBK2DJFCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJWHAZTKOBWHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

melanke · 2025-07-15T01:23:15Z

@GulAhmedshah yes, you actually didn't revert the changes to the files I mentioned. Let me know if you need help with git.

GulAhmedshah · 2025-07-15T07:22:42Z

Yes sir please help me out How can I revert the changes.

GulAhmedshah · 2025-07-15T07:24:43Z

Pleas, also make it clear to me that if I made some changes in project then I should just simply push it to the repo?

GulAhmedshah · 2025-07-15T07:57:47Z

An other option with me is to clone the project and again make my changes and push and PR the changes? should I go this way?

melanke · 2025-07-15T13:47:07Z

@GulAhmedshah Yes, you can simply push to your branch and the PR will be updated.

Send me a DM on Telegram so we can talk about reverting changes with Git.

melanke

Thank you for the update.

packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx

melanke · 2025-07-16T13:46:15Z

packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx

+          height={100}
+          className="rounded-full object-cover shadow-sm mx-auto mb-4"
+          priority
+          unoptimized


Please, optimize it! hahaha

haha sir but when I optimize it, it require me to update the next config file. M I allowed to do that?

melanke · 2025-07-17T00:03:49Z

packages/nextjs/next.config.ts

@@ -3,6 +3,9 @@ import type { NextConfig } from "next";
 const nextConfig: NextConfig = {
  reactStrictMode: true,
  devIndicators: false,
+  images: {
+    domains: ["avatars.githubusercontent.com"],


domains is deprecated, please, use remotePatterns instead.

vercel bot deployed to Preview July 11, 2025 21:28 View deployment

melanke requested changes Jul 14, 2025

View reviewed changes

GulAhmedshah force-pushed the BiedGuidTask branch from 75a216c to 8c6175d Compare July 14, 2025 21:00

vercel bot deployed to Preview July 14, 2025 21:03 View deployment

GulAhmedshah force-pushed the BiedGuidTask branch from 8c6175d to 4c83832 Compare July 14, 2025 21:27

vercel bot had a problem deploying to Preview July 14, 2025 21:28 Failure

GulAhmedshah force-pushed the BiedGuidTask branch from 4c83832 to a2960b8 Compare July 15, 2025 18:51

vercel bot deployed to Preview July 15, 2025 18:54 View deployment

GulAhmedshah force-pushed the BiedGuidTask branch from a2960b8 to 9370e51 Compare July 15, 2025 20:36

vercel bot deployed to Preview July 15, 2025 20:38 View deployment

melanke requested changes Jul 15, 2025

View reviewed changes

packages/nextjs/app/builders/0xaC1bBf2Aba61D6fC6fCbade72eCe3362de4724c3/page.tsx Show resolved Hide resolved

GulAhmedshah added 2 commits July 16, 2025 13:09

reverting files and updating personal pages

99f27db

aligned personal page with config file

d89c29d

GulAhmedshah force-pushed the BiedGuidTask branch from 9370e51 to d89c29d Compare July 16, 2025 09:05

vercel bot deployed to Preview July 16, 2025 09:07 View deployment

melanke reviewed Jul 16, 2025

View reviewed changes

optimized picture

ef6d769

vercel bot deployed to Preview July 16, 2025 21:59 View deployment

melanke reviewed Jul 17, 2025

View reviewed changes

Completed task-a and task-b #24

Are you sure you want to change the base?

Completed task-a and task-b #24

Uh oh!

Conversation

GulAhmedshah commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional Information

Related Issues

Uh oh!

vercel bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melanke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GulAhmedshah commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GulAhmedshah commented Jul 14, 2025 via email

Uh oh!

melanke commented Jul 15, 2025

Uh oh!

GulAhmedshah commented Jul 15, 2025

Uh oh!

GulAhmedshah commented Jul 15, 2025

Uh oh!

GulAhmedshah commented Jul 15, 2025

Uh oh!

melanke commented Jul 15, 2025

Uh oh!

melanke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GulAhmedshah commented Jul 11, 2025 •

edited

Loading

vercel bot commented Jul 11, 2025 •

edited

Loading

GulAhmedshah commented Jul 14, 2025 •

edited

Loading