Add builders page. #31
Open
+97
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
melanke
requested changes
Jul 17, 2025
| import { useScaffoldEventHistory } from "~~/hooks/scaffold-eth"; | ||
|
|
||
| type Props = { | ||
| builders: string[]; |
There was a problem hiding this comment.
This parameter name is confusing. It shouldn’t represent all builders, only those who have a profile page.
Comment on lines
+25
to
+68
| <table className="table overflow-hidden"> | ||
| <thead> | ||
| <tr> | ||
| <th>Member Address</th> | ||
| <th>Contract Address</th> | ||
| <th>Personal Profile</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {!filteredEvents || filteredEvents.length === 0 ? ( | ||
| <tr> | ||
| <td colSpan={3} className="text-center"> | ||
| No Data | ||
| </td> | ||
| </tr> | ||
| ) : ( | ||
| filteredEvents?.map((event, index) => { | ||
| return ( | ||
| <tr key={index}> | ||
| <td> | ||
| <Address address={event.args.builder} format="short" onlyEnsOrAddress /> | ||
| </td> | ||
| <td> | ||
| <Address address={event.args.checkInContract} format="short" onlyEnsOrAddress /> | ||
| </td> | ||
| <td> | ||
| {builders.includes(event.args.builder ?? "") ? ( | ||
| <Link | ||
| href={`builders/${event.args.builder}`} | ||
| target="_blank" | ||
| className="text-base text-blue-600 underline hover:text-blue-800 cursor-pointer whitespace-nowrap" | ||
| > | ||
| 🧑💻 builders/{event.args.builder} | ||
| </Link> | ||
| ) : ( | ||
| "N/A" | ||
| )} | ||
| </td> | ||
| </tr> | ||
| ); | ||
| }) | ||
| )} | ||
| </tbody> | ||
| </table> |
There was a problem hiding this comment.
Is this table good on mobile devices?
There was a problem hiding this comment.
one suggestion @byte-hedgy Wrap your table in a div with overflow-x-auto and w-full
There was a problem hiding this comment.
one suggestion @byte-hedgy Wrap your table in a div with overflow-x-auto and w-full
It might feel a bit clunky to have horizontal scrolling within a vertical scroll. Since there isn’t that much info, a simple vertical list of cards could work nicely!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
builders/page.tsxto display information about checked-in builders.headnavigation.Regarding the issue in #3, the problem might have been caused by the default
blocksBatchSizevalue of500, which led the browser to continuously send requests without showing any results. One of the requests triggered a "too many requests" error, which may have caused repeated retries.I’ve increased
blocksBatchSizeto5000000, and now everything works as expected.Screenshots below:
Additional Information
Related Issues
Closes #3
Your ENS/address: 0xADAeE26D04f78D24F2E73D87944f83E2eE50d6BB