Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OSM feature generation capabilities #43

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SmylerMC
Copy link
Collaborator

@SmylerMC SmylerMC commented Aug 13, 2021

Goal:

This PR aims to improve the way OSM features are generated into the world. It focuses on implementing new flexible internal mechanics so that users can configure OSM generation to suite their needs through the osm.json5 config. Actually implementing the new generation improvements in osm.json5 will happen in a separate PR as it will probably be subject to debates over personal preferences on how things look in-game.

Progress

  • Internal support for setting surface blocks at any height
  • Internal support for setting surface blocks depending on the position and on a Random
  • osm.json5 support for multiblock patterns
  • osm.json5 support for randomized patterns
  • Doted SharpLines
  • Internal support to generate small structures at the location of Points
  • osm.json5 support for structures

Implementation

I'm trying to build on top of the current implementation to keep things as fast as they are, but a few changes have to be made to support the new features:

@SmylerMC SmylerMC self-assigned this Aug 13, 2021
@DaMatrix
Copy link
Member

this may be better suited to do on 2.0, as i've rewritten (and will be doing further major changes to) a lot of the OSM parsing code.

@SmylerMC
Copy link
Collaborator Author

this may be better suited to do on 2.0, as i've rewritten (and will be doing further major changes to) a lot of the OSM parsing code.

Ok, I'll be starting fresh from a new branch to avoid annoying conflicts then, do you think you could merge back master into dev/2.0 so it is up to date ?

@FireFragment FireFragment mentioned this pull request Aug 3, 2022
@SmylerMC SmylerMC mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants