chore[gen-2]:ENG-8051 added model-name and api-key in the builder.sdkInfo-event #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3ca7695 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 3ca7695.
☁️ Nx Cloud last updated this comment at |
samijaber
requested changes
Jan 30, 2025
There was a problem hiding this comment.
- Your changeset needs to be updated to apply to Gen2 SDKs and not the Gen1 Core
- Could you add some testing to make sure we are sending the correct values? @yash-builder can help walk you through our e2e testing setup
Co-authored-by: Sami Jaber <[email protected]>
samijaber
reviewed
Feb 3, 2025
yash-builder
reviewed
Feb 4, 2025
samijaber
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sending "modalName" and "apiKey" from sdk gen-2.
These data are added to the event "builder.sdkInjected".