Vue SDK: stop passing down unused props

[samijaber]

Description

https://builder-io.atlassian.net/browse/ENG-7615

[changeset-bot]

🦋 Changeset detected

Latest commit: b333015

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@builder.io/sdk-vue	Patch
@builder.io/sdk-angular	Patch
@builder.io/sdk-react-nextjs	Patch
@builder.io/sdk-qwik	Patch
@builder.io/sdk-react	Patch
@builder.io/sdk-solid	Patch
@builder.io/sdk-svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[nx-cloud]

View your CI Pipeline Execution ↗ for commit b333015.

Command	Status	Duration	Result
nx test @e2e/qwik-city	❌ Failed	8m 20s	View ↗
nx test @e2e/nuxt	❌ Failed	6m 45s	View ↗
nx test @e2e/svelte	✅ Succeeded	10m 32s	View ↗
nx test @e2e/solid-start	✅ Succeeded	10m 44s	View ↗
nx test @e2e/gen1-next14-pages	✅ Succeeded	9m 27s	View ↗
nx test @e2e/nextjs-sdk-next-app	✅ Succeeded	9m 1s	View ↗
nx test @e2e/react-sdk-next-pages	✅ Succeeded	7m 9s	View ↗
nx test @e2e/gen1-react	✅ Succeeded	8m 10s	View ↗
Additional runs (36)	✅ Succeeded	...	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-03-27 12:34:47 UTC

[samijaber]

@sidmohanty11 I think I'm breaking this code with this PR. My change here is fine but the ngOnChanges overrides below in this same plugin will stop working:

ngOnChanges(changes: SimpleChanges) { if (changes["attributes"] && !this.hasAttributesInput(this.Wrapper)) { this.ngAfterViewInit(); }

what do you suggest we do about this? Also, is there anything else that will start to break with this approach?

if it's too hard to make the angular SDK happy with not having an attributes prop, i can look into bringing it back in this plugin instead

[sidmohanty11]

@samijaber breaking up attributes will mean that we'll lose access to builder-id, style etc so now we'll have to attach all props as HTML attributes and not pass them to be reactive (as inputs). Is it possible to keep the attributes key? because here:

builder/packages/sdks/mitosis.config.cjs

Lines 723 to 731 in f9b8552

	ngAfterViewInit() {
	if (!this.hasAttributesInput(this.Wrapper)) {
	const wrapperElement =
	this.wrapperTemplateRef.elementRef.nativeElement?.nextElementSibling;
	if (wrapperElement) {
	this.updateAttributes(wrapperElement, this.attributes);
	}
	}
	}

we check if that element doesn't have attributes as an input then we spread it out in the element

[sidmohanty11]

else we can look for only these four: id, style, href and className as attributes and send everything else as inputs

[gitguardian]

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9071768	Triggered	Generic High Entropy Secret	4740de2	packages/sdks-tests/src/specs/video-lazy-load.ts	View secret
2708648	Triggered	Generic High Entropy Secret	4740de2	examples/angular-gen2/src/environments/environment.ts	View secret
9071769	Triggered	Generic High Entropy Secret	4740de2	packages/sdks-tests/src/specs/video-lazy-load.ts	View secret
314150	Triggered	Generic High Entropy Secret	4740de2	packages/sdks/src/functions/get-content/snapshots/generate-content-url.test.ts.snap	View secret
11707119	Triggered	Generic High Entropy Secret	4740de2	packages/sdks/snippets/sveltekit/src/routes/editable-region/+page.svelte	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[sidmohanty11]

@samijaber this needs a changeset

as the accordion VE is actually failing: https://www.loom.com/share/036fda4959c9473aa0604299097b7a64 we can skip it for now

[samijaber]

@samijaber this needs a changeset

The student has become the master

[sidmohanty11]

🚀