fmt: remove all uses of ranged integers from jiff::fmt internals
#482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This continues the journey started in 808905c.
This also rips them out of the utility functions in `fmt`. (This was already intentionally quite light on ranged integer usage, since I had written that code recently and figured I'd be ripping things out.) This did require defining more bounds types, including, notably, the bounds for `Span` and for `Timestamp`.
This was driving be bonkers. Everything else uses `print.rs` (when parsing and printing are in separate modules).
I did this originally to aid error messages by reflecting back precisely what was in the input. But I've been trending away from that, and we should be able to get most of the value here by just using the `Display` impls of what we parsed. That's what we do here. Happily, this seems to result in a speed-up: ``` $ critcmp baseline x01 -f civil_datetime group baseline x01 ----- -------- --- parse/civil_datetime/jiff 1.42 24.9±0.16ns ? ?/sec 1.00 17.5±0.20ns ? ?/sec ``` Which makes sense. Previously, we were infecting the happy path with code for capturing the input. But really, that should be on the unhappy path (i.e., error handling/printing).
This should now include the new `Bounds` error type.
The `jiff::fmt` module is now completely free of ranged integer types. w00t. Easier than I expected, but I also suspected this would be one of the easier parts of the migration since `jiff::fmt` lives at the boundaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much what it says on the tin.
This continues in a similar vein as #480.