fix: correct padding with negative values in strftime #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #485 where the padding values when using a space as the padding byte adds the '-' sign before the spaces. This approach tried to separate the logic for adding the padding from the happy path since there has been a bunch of optimization work done to make this faster and its a rare case to have negative numbers.
The overarching purpose of this fix is to use it in uutils coreutils: uutils/coreutils#10242