Bugfix: Correct File Chunk Stream Reading #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue where the file upload would not read and upload the file chunks successfully. The original code incorrectly assumed that Stream.Read() would always read a full chunk of data from the file stream, when in reality it may return read fewer bytes. To solve this, the new UploadChunkAsync helper method ensures the entire chunk is read from the stream before proceeding with the upload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where the file upload would not read and upload the file chunks correctly. The original code incorrectly assumes that
Stream.Read()would always read a full chunk of data from the file stream, when in reality it may return read fewer bytes. To solve this, the newUploadChunkAsynchelper method ensures the entire chunk is read from the stream before proceeding with the upload.