Skip to content

Add thread continuation support through 'and' keyword (continueLast) #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

wolfmanstout
Copy link
Collaborator

  • Add thread.talon-list with 'and: continueLast' to continue the most recent conversation
  • Add thread parameter to all model functions and commands
  • Display warning when thread continuation is attempted without the llm CLI
  • Support the thread parameter everywhere {user.model} is used

Thread continuation works with all model commands, e.g.:

  • 'model and explain this'
  • 'four o mini and shell list all directories'

This feature currently requires setting user.model_endpoint = 'llm'

wolfmanstout and others added 2 commits March 30, 2025 15:40
- Add thread.talon-list with 'and: continueLast' to continue the most recent conversation
- Add thread parameter to all model functions and commands
- Display warning when thread continuation is attempted without the llm CLI
- Support the thread parameter everywhere {user.model} is used

Thread continuation works with all model commands, e.g.:
- 'model and explain this'
- 'four o mini and shell list all directories'

This feature currently requires setting user.model_endpoint = 'llm'
@C-Loftus
Copy link
Owner

Looks good to me. Just wanted to clarify the reasoning behind having the thread command in a talon list with one item. Is that so it can be overriden and customized? Or do we intend on one day allowing for more complex thread specifiers beyond just continuing the last thread?

mod.list("thread", desc="Which conversation thread to continue")
list: user.thread
-
and: continueLast

@wolfmanstout
Copy link
Collaborator Author

It is a bit of both but more for current implementation. I could imagine that we add support for named threads, which might need more than just a list (although if it's just hardcoded conversation IDs I guess that could work). I generally try to avoid overdesigning for a future I haven't yet worked out, but this seemed useful enough in the near term just for the current purposes. If I put an optional literal in the command spec I don't have a way to figure out in the Talon file whether it was specified.

@C-Loftus
Copy link
Owner

Makes sense, feel free to merge when you are happy

@wolfmanstout wolfmanstout merged commit c2331e2 into C-Loftus:main Apr 1, 2025
5 checks passed
@wolfmanstout wolfmanstout deleted the add-thread-option branch April 1, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants