Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocryptox509: return "actual" validation result #64

Merged
merged 1 commit into from
Nov 2, 2023
Merged

gocryptox509: return "actual" validation result #64

merged 1 commit into from
Nov 2, 2023

Conversation

tnytown
Copy link
Contributor

@tnytown tnytown commented Nov 2, 2023 •
edited
Loading

Also reworks the verification logic a little to generate more helpful context.

Fixes #63.

@tnytown
Copy link
Contributor Author

tnytown commented Nov 2, 2023

Results: https://github.com/trailofbits/x509-limbo/actions/runs/6727906208/attempts/1#summary-18286411031

@woodruffw
Copy link
Collaborator

LGTM, thanks @tnytown!

@woodruffw woodruffw merged commit b98c78c into main Nov 2, 2023
6 checks passed
@woodruffw woodruffw deleted the ap/issue/63 branch November 2, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw Awaiting requested review from woodruffw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go harness is returning computed result rather than "actual" result
2 participants
@tnytown @woodruffw