Skip to content

CRDCDH-1094 Create new Data Submission changes. New intention and added dataType #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2024

Conversation

Alejandro-Vega
Copy link
Collaborator

Overview

Updated the create new data submission dialog to consider new Submission intention as well as adding the Submission Data Type property.

Change Details (Specifics)

  • Moved intention radio options in create submission dialog to the top of the dialog instead of below.
  • Added dataType property to Submission. This will be for specifying if the submission is for both metadata and data files, or just metadata.
  • Updated getSubmission query and createSubmission mutation to include dataType
  • Updated type of intention property to contain "New/Update" instead of having them separate options
  • Updated tests due to the new type changes as well as the addition of property dataType
  • Disabled "Metadata and Data Files" dataType option when intention is "Delete"
  • The dataType option "Metadata and Data Files" is set to selected by default

Related Ticket(s)

CRDCDH-1094

@Alejandro-Vega Alejandro-Vega added the 🚧 Do Not Merge This PR is not ready for merging label May 24, 2024
@Alejandro-Vega Alejandro-Vega added this to the 3.0.0 (PMVP-M1) milestone May 24, 2024
@Alejandro-Vega Alejandro-Vega marked this pull request as ready for review May 28, 2024 14:50
@Alejandro-Vega Alejandro-Vega requested a review from amattu2 May 28, 2024 14:50
@Alejandro-Vega Alejandro-Vega removed the 🚧 Do Not Merge This PR is not ready for merging label May 28, 2024
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amattu2 amattu2 merged commit 8d5f4bc into 3.0.0 May 28, 2024
5 checks passed
@amattu2 amattu2 deleted the CRDCDH-1094 branch May 28, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants