Skip to content

CTDC Model now with Versions, correct quotes, and preserved indentations #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

pihltd
Copy link
Collaborator

@pihltd pihltd commented Jul 30, 2024

No description provided.

PhilipMusk and others added 5 commits July 16, 2024 23:02
Moved references to properties not yet assigned CDEs out of plain sight

Continued with model-wide cleaning-up an commenting out

Checked and modified key field indicators as necessary

Added and/or modified numerous additional CDE references per 06-24-24 input from the SI team
Resolved duplications within SNOMED disease term acceptable values introduced as of the associated SNOMED codes having been commented out
Added CDE references as follows:
For 4 properties within the subject node

For 2 "date" properties within the targeted_therapy node

For 2 "date" properties within the non_ targeted_therapy_node

For 2 "date" properties within the radiotherapy node

For 3 properties within the specimen node
An update that added CDE versions and kept the single quotes throughout.
@pihltd pihltd requested review from majensen and PhilipMusk July 30, 2024 18:38
Copy link
Collaborator

@PhilipMusk PhilipMusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having done a near line-by-line review of the changes represented here, some of which was done with Todd involved, this looks good to go.

All of the indentation inadvertently removed during the addition of CDE version numbers has been correctly reverted out.

All of the terms that need to be within single quotes are likewise now correctly back within single quotes.

All of the terms that need to quoted within double quotes are likewise now correctly back within double quotes.

And all of the most recent CDE references that I inserted are safely where they should be.

The only issue of note is that there are a handful of properties for which there is a valid CDE reference in place, for which there is no corresponding CDE version number, an issue which Todd is aware of, and planning to address accordingly.

I'm @PhilipMusk, and I approve this PR

Copy link
Collaborator

@majensen majensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kuffelgr kuffelgr changed the base branch from master to develop August 6, 2024 14:24
@PhilipMusk PhilipMusk merged commit 8fc33a8 into develop Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants