Skip to content

Update props #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2024
Merged

Update props #21

merged 1 commit into from
Aug 14, 2024

Conversation

kuffelgr
Copy link
Collaborator

This PR addresses validation errors from the CRDC Data Hub:

  • Removes additional key prop from the Biospecimen node
  • Changes the data_file_uuid property to not required so that example files do not have to include values for this property since we will not expect submitter to provide this.

@kuffelgr kuffelgr requested review from n2iw, pihltd and PhilipMusk August 14, 2024 20:22
pihltd
pihltd approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@pihltd pihltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change appears correct, parent_specimen_id is no longer Key, and data_file_uuid is no longer a required field.

@kuffelgr kuffelgr merged commit 467214a into develop Aug 14, 2024
2 checks passed
@kuffelgr kuffelgr deleted the remove-key-prop branch August 14, 2024 20:33
@amattu2 amattu2 mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pihltd pihltd pihltd approved these changes

@n2iw n2iw Awaiting requested review from n2iw

@PhilipMusk PhilipMusk Awaiting requested review from PhilipMusk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuffelgr @pihltd