Fix #168 Update Model per STS01 and OSA04 requirements - polish #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the controlled vocabulary for the file_type property putting acceptable terms into alphabetical order; existing order was entirely arbitrary and was being propagated as is into the Data Model Navigator, where it really should be presented in a logical order.
Unrelated to either the STS01 or the OSA04 studies: Changed cardinality of the relationship between diagnosis and case from many_to_one to one_to_one Updated the dose_limiting_toxicity and unexpected_adverse_event properties with the adverse_event node from Required to Preferred, in order to accommodate the blanks values we're seeing in the data generated by the PRECINCT01 and PRECINCT02 studies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the controlled vocabulary for the file_type property putting acceptable terms into alphabetical order; existing order was entirely arbitrary and was being propagated as is into the Data Model Navigator, where it really should be presented in a logical order.