Skip to content
This repository was archived by the owner on Nov 28, 2017. It is now read-only.

Add new instance action: Resize. #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xuhang57
Copy link
Collaborator

@xuhang57 xuhang57 commented Mar 9, 2017

Add a missing instance action: Resize.

screen shot 2017-03-09 at 15 07 16

Backend change: # 29

Description

Add a new action in the action bar: Resize. It will tell the user the quota change after resizing the instance. Work with v2/instances in the atmosphere. This PR needs refactor and I am trying my best to take out unused functions out from a few files. But, it has been tested and it could work, although producing production quality code is my goal 💯

Checklist before merging Pull Requests

  • Refactor
  • Unit test for the new functionality.
  • Reviewed and approved by at least one other contributor.
  • Wishlist

Wishlist:

  • Have a new form rather than Resource Form
  • Show the current flavor size.
  • Disallow to resize for the at size
  • Preventing any user from "downsize" the instance.

Thanks
Lucas

@jeremyfreudberg
Copy link
Member

Hey Lucas, I logged in on 140 but I don't see resize option there.

Also, curious about this:

Prevent user from resizing the instance from a larger flavor to a smaller one.

Resizing should work both ways.

@xuhang57
Copy link
Collaborator Author

xuhang57 commented Mar 9, 2017

@jeremyfreudberg Thanks for checking! So your instance has to be at the final state (you will see a green circle and text as Active under the status column) to use resize action.

And currently, i am still working the PR so I am using it as a test server, which means, it is not so stable and it would be great if you could wait till tomorrow.

To answer your second question:

Rado discovered a problem about it. We can discuss this when you are at the team room. In general, there is a upstream bug about it. I'd happy to chat with you on this issue and figure out a solution.

@xuhang57 xuhang57 removed the WIP label Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants