Merged
Conversation
| try { | ||
| // Prevent default form behavior | ||
| const token = await mockLogin(data.email, data.password); | ||
| console.log(token) |
| export const mockLogin = async (username: string, password: string) => { | ||
| // Simulate API call delay | ||
| await new Promise(resolve => setTimeout(resolve, 1000)); | ||
| console.log('login', username, password); |
Collaborator
There was a problem hiding this comment.
probably remove.
knguyenrise8
force-pushed
the
feat/RV-386-login-screen
branch
from
420923d to
069020d
Compare
arinkulshi-skylight
approved these changes
Jan 10, 2025
Collaborator
arinkulshi-skylight
left a comment
arinkulshi-skylight
left a comment
There was a problem hiding this comment.
LGTM! minor edits
Collaborator
Author
thanks Arin made the updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
login screen
Screenshots (if applicable)
Related Issues
[Link any related issues or tasks from your project management system.]
Checklist