-
Notifications
You must be signed in to change notification settings - Fork 67
Rebalance #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rebalance #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces several small changes to Laghos aimed at improving build flexibility, GPU kernel timing accuracy, and mesh handling. Key changes include:
- Inclusion of an optional user.mk file in the makefile and enhanced MFEM directory resolution.
- Updates to use HYPRE_BigInt types for global sizes in laghos_solver.hpp and laghos.cpp to fix integer overflow issues.
- Addition of GPU device synchronization (LAGHOS_DEVICE_SYNC) calls in laghos_solver.cpp and new command-line options in laghos.cpp to enable non-conforming meshes and mesh rebalancing.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
makefile | Added inclusion of user.mk and refined MFEM directory comparisons. |
laghos_solver.hpp | Updated global true vector size types from HYPRE_Int to HYPRE_BigInt. |
laghos_solver.cpp | Inserted LAGHOS_DEVICE_SYNC calls around GPU kernel launches and timing sections. |
laghos.cpp | Introduced options for non-conforming meshes and mesh rebalancing; updated types. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
vladotomov
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small changes to Laghos: