Skip to content

Rebalance #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 10, 2025
Merged

Rebalance #193

merged 9 commits into from
May 10, 2025

Conversation

helloworld922
Copy link
Collaborator

Various small changes to Laghos:

  • Fixed building if mfem is installed in a symlink'd folder
  • Added optional user.mk file for user build config
  • Added option to force non-conforming meshes (in 2D and 3D)
  • Added option to rebalance mesh after parallel refinement
  • Ensure timing sections measure GPU kernel execution correctly
  • Fixed some integer overflow problems with FOM calculations

@tzanio tzanio requested review from Copilot and vladotomov May 9, 2025 11:35
@tzanio tzanio self-assigned this May 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces several small changes to Laghos aimed at improving build flexibility, GPU kernel timing accuracy, and mesh handling. Key changes include:

  • Inclusion of an optional user.mk file in the makefile and enhanced MFEM directory resolution.
  • Updates to use HYPRE_BigInt types for global sizes in laghos_solver.hpp and laghos.cpp to fix integer overflow issues.
  • Addition of GPU device synchronization (LAGHOS_DEVICE_SYNC) calls in laghos_solver.cpp and new command-line options in laghos.cpp to enable non-conforming meshes and mesh rebalancing.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

File Description
makefile Added inclusion of user.mk and refined MFEM directory comparisons.
laghos_solver.hpp Updated global true vector size types from HYPRE_Int to HYPRE_BigInt.
laghos_solver.cpp Inserted LAGHOS_DEVICE_SYNC calls around GPU kernel launches and timing sections.
laghos.cpp Introduced options for non-conforming meshes and mesh rebalancing; updated types.

helloworld922 and others added 2 commits May 9, 2025 07:32
@vladotomov vladotomov merged commit a2ad322 into CEED:master May 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants