-
Notifications
You must be signed in to change notification settings - Fork 10
[4주차] 한서정 미션 제출합니다. #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4주차 과제 수고하셨습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
데이터는 json 파일로 작성하면 더 좋을 것 같아요!
messenger/src/assets/종류=선택 취소.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete.svg랑 같은 파일 같아요
onClick, | ||
}) => { | ||
return ( | ||
<button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
button type 기본이 submit이라 따로 지정해주면 좋을 것 같습니다!
const search = ''; | ||
const [selectedId, setSelectedId] = useState<number | null>(null); | ||
|
||
const filtered = cafes.filter((c: Cafe) => c.name.includes(search.trim())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변수명을 좀 더 정확히 해주면 좋을 것 같습니다!
type === 'white' | ||
? 'border-b-gray-100 bg-white text-black' | ||
: 'text-white [background:var(--Green-gradient,linear-gradient(0deg,rgba(0,0,0,0.10)_0%,rgba(0,0,0,0.10)_100%),linear-gradient(90deg,#5AE587_0%,#16BBC5_100%))]' | ||
}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cn utils 활용하면 더 편하게 코드 작성할 수 있을 것 같아요!
<div className="relative flex w-full items-center self-stretch"> | ||
{/* 왼쪽 아이콘 */} | ||
<div | ||
className="absolute top-1/2 left-0 -translate-x-0 -translate-y-1/2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
button 태그 사용하면 좋을 것 같아요!
<nav className="absolute right-0 bottom-0 left-0 flex h-[5.25rem] items-start justify-center gap-[2.0625rem] bg-white px-5 pt-2 pb-0 shadow-[0px_-10px_20px_0px_rgba(0,0,0,0.03)]"> | ||
{navItems.map((item, i) => ( | ||
<button | ||
key={i} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
key는 index 말고 고유한 값을 지정해주세요!
|
||
@layer components { | ||
.h1 { | ||
@apply text-[60px] leading-[140%] font-bold tracking-[-0.01em]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text는 rem 단위를 쓰는게 적절할 것 같습니다
const location = useLocation(); | ||
const nav = useNavigate(); | ||
|
||
const navItems = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상수는 대문자로 써주면 더 좋을 것 같습니다
배포 링크
링크
배운점& 느낀점
시험기간과 여러 중요한 일정들이 너무 겹쳐서 이번 미션은 구현해야하는 기능들의 최소한만 구현하게 되었습니다... 코드에 부족한 점이 많아요ㅜㅜㅠ 죄송합니다 다음주 미션은 200퍼센트로 완성하겠습니다..ㅠㅜㅠㅠ
추가로 채팅방 생성 페이지를 만들었습니다. 근데 채팅방 추가 후 채팅 리스트에도 보이도록 만드려면 데이터 구조를 갈아 엎어야 하는데 그럴 시간이 정말 없어서 구현 못한 점 양해 부탁드립니다..ㅜㅠ
key question
React Router의 동적 라우팅이란 무엇이며, 언제 사용하나요?
/posts/:postId
같은 형태로 여러 개의 상세 페이지를 한 번에 처리할 때 사용느린 네트워크 환경에서 UX를 개선하기 위한 전략과 최적화 방법
useState·useReducer vs. Context API vs. 전역 상태 라이브러리 차이