-
Notifications
You must be signed in to change notification settings - Fork 10
[2주차] 안혜연 미션 제출합니다. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noeyeyh
wants to merge
11
commits into
CEOS-Developers:master
Choose a base branch
from
noeyeyh:noeyeyh
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b0e1973
feature: 할 일 입력과 삭제 기능
noeyeyh 463a4a2
docs: 할 일 목록 리스트 컴포넌트 분리
noeyeyh f2e821e
feat: 완료한 개수, 날짜 추가
noeyeyh dd636d0
style: 폰트 적용
noeyeyh 4edf5ac
style: 반응형 추가
noeyeyh 806a548
feat: 로컬스토리지 저장 및 불러오기 추가
noeyeyh 13df877
style: 텍스트 줄바꿈 추가
noeyeyh 0d5baa1
feat: React.memo 적용
noeyeyh 154dc62
docs: readme 작성
noeyeyh 0db396e
docs: readme 수정
noeyeyh f4c872f
chore: 코드 리뷰 반영
noeyeyh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"trailingComma": "es5", | ||
"tabWidth": 2, | ||
"semi": true, | ||
"singleQuote": true | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,15 @@ | ||
function App() { | ||
import React from 'react'; | ||
import { BrowserRouter, Routes, Route } from 'react-router-dom'; | ||
import ToDoList from './pages/ToDoList'; | ||
import GlobalStyles from '../src/GlobalStyles'; | ||
|
||
export default function App() { | ||
return ( | ||
<div className="App"> | ||
<h1>CEOS 19기 프론트엔드 파이팅!( ¨̮ )و✧🔥</h1> | ||
</div> | ||
<BrowserRouter> | ||
<GlobalStyles /> | ||
<Routes> | ||
<Route path="/" element={<ToDoList />} /> | ||
</Routes> | ||
</BrowserRouter> | ||
); | ||
} | ||
|
||
export default App; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lang 속성은 웹 페이지의 언어를 선언하는데요,
아무래도
<html lang="en">
에서"ko"
로 바꾸는게 낫겠죠 ? > <There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그리고 이렇게 불필요한 파일들과 태그는 처음 React 프로젝트를 생성 또는 클론하고, 구현 시작 전 초기세팅 시 싹 지워주고 시작하면 좋아요!! > <
나중에 왜 이 파일 있는데 안썼냐! 하는 경고나 에러가 뜰 수도 있고, 파일명이나 모듈명이 겹치면 골치아파질 수 있기 때문이랍니당 😆