videos: transform related identifiers #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubeydecivelek
force-pushed
the
related_identifiers
branch
from
69a9562 to
8f0a122
Compare
zzacharo
reviewed
May 30, 2025
cds_migrator_kit/videos/weblecture_migration/transform/xml_processing/quality/identifiers.py
Outdated
Show resolved
Hide resolved
cds_migrator_kit/videos/weblecture_migration/transform/xml_processing/quality/identifiers.py
Outdated
Show resolved
Hide resolved
cds_migrator_kit/videos/weblecture_migration/transform/xml_processing/rules/video_lecture.py
Outdated
Show resolved
Hide resolved
cds_migrator_kit/videos/weblecture_migration/transform/xml_processing/quality/identifiers.py
Outdated
Show resolved
Hide resolved
zubeydecivelek
force-pushed
the
related_identifiers
branch
4 times, most recently
from
3c628ff to
665baa4
Compare
zzacharo
reviewed
Jun 3, 2025
| @@ -145,7 +156,10 @@ def url_files(self, key, value): | |||
|
|
|||
| return {"indico": indico_link} | |||
|
|
|||
| url_file = {"url_file": {"url": url}} | |||
| url_file = {"url_file": {}} | |||
There was a problem hiding this comment.
on line 145 when you set the indico_link["event_id"] maybe verify with the 084 field and if not the same raise?
There was a problem hiding this comment.
Yes sorry, I meant the 970
There was a problem hiding this comment.
Should we also raise if there's no indico_id?
There was a problem hiding this comment.
we can so we gather some statistics but I would raise it as a warning
zubeydecivelek
force-pushed
the
related_identifiers
branch
3 times, most recently
from
717f2cc to
a2cb3ca
Compare
zubeydecivelek
force-pushed
the
related_identifiers
branch
from
a2cb3ca to
a9a4ff0
Compare
zzacharo
reviewed
Jun 4, 2025
| } | ||
| if rel not in related_identifiers: | ||
| related_identifiers.append(rel) | ||
| elif len(event_ids) > 1: |
There was a problem hiding this comment.
that is wrong because if we have the same event_id in both fields it would raise no?
There was a problem hiding this comment.
No I created a set of all the indico id's in the record. Line 340-353, so it'll raise only if there is another indico id
zzacharo
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes CERNDocumentServer/cds-videos#2031