Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player: add theoplayer license as config #1934

Merged

Conversation

jrcastro2
Copy link
Contributor

@jrcastro2 jrcastro2 commented Jan 11, 2024

  • uses license key instead of built SDK only

@ntarocco ntarocco force-pushed the theoplayer-license-as-config branch from 3db7c37 to 0f3de27 Compare January 12, 2024 17:02
@ntarocco ntarocco closed this Jan 12, 2024
@ntarocco ntarocco reopened this Jan 12, 2024
@ntarocco ntarocco force-pushed the theoplayer-license-as-config branch from 0f3de27 to d4782cf Compare January 12, 2024 17:04
* uses license key instead of built SDK only
@ntarocco ntarocco force-pushed the theoplayer-license-as-config branch from d4782cf to c1810de Compare January 12, 2024 17:32
@ntarocco ntarocco requested a review from zzacharo January 12, 2024 17:32
@ntarocco
Copy link
Contributor

Tested in Sandbox, fixing tests.

zzacharo
zzacharo previously approved these changes Jan 15, 2024
Copy link
Contributor

@zzacharo zzacharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

zzacharo
zzacharo previously approved these changes Jan 15, 2024
@ntarocco ntarocco force-pushed the theoplayer-license-as-config branch from 939cb71 to 5d9d269 Compare January 15, 2024 16:58
@ntarocco ntarocco merged commit 4d8499c into CERNDocumentServer:main Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants